[DOCS]: enforce_admins description understates what it covers and omits push restrictions
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 78/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- go, terraform
- Domain
- documentation
Research direction
Update the descriptions of enforce_admins in github_branch_protection and github_branch_protection_v3. Start by locating those resource descriptions and checking the linked GitHub documentation for the stated scope and bypass behavior. Done when the descriptions explain which protections apply to administrators, exclude push restrictions, and clarify that bypass lists still apply when enforce_admins is true.
Written by the indexing model from the issue text.
Description
Describe the need
github_branch_protection and github_branch_protection_v3 describe enforce_admins as enforcing "status checks for repository administrators". It actually applies most of the branch protection to administrators (pull request, linear history, signed commit and lock requirements too), but not push restrictions, which administrators can always bypass.
The bypass lists also don't say whether they still apply when enforce_admins is true. They do.
Code of Conduct
- I agree to follow this project's Code of Conduct
- Dominant language
- Go
- Stars
- 1.2k
- Forks
- 1.1k
- Avg merge
- 9h 41m
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from integrations/terraform-provider-github
-
[FEAT]: Add ruleset bypass actor type `OrganizationRole`Possibly taken @marcencov claimed this 15 days ago. OpenStatus: Triage Type: Feature
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
integrations/terraform-provider-github#3674 · 3 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Type: Bug Upstream
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
integrations/terraform-provider-github#3660 · 2 comments · 2 reactions ·
Maintainers usually reply within 1 day
-
github_organization_custom_properties Read doesn't handle 404, breaking recovery after deletionPossibly taken @mkushakov claimed this 244 days ago. Openr/organization_custom_properties Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
integrations/terraform-provider-github#3641 · 1 comment ·
Maintainers usually reply within 1 day
-
Status: Triage Type: Feature
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
integrations/terraform-provider-github#3613 · 1 comment · 3 reactions ·
Maintainers usually reply within 1 day
-
[BUG]: Out-of-band removal of environment reviewers is not detected on refreshPossibly taken @nitinjain999 claimed this 68 days ago. Openr/repository_environment Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
integrations/terraform-provider-github#3609 · 3 comments · 1 reaction ·
Maintainers usually reply within 1 day
All issues in integrations/terraform-provider-github
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
cloudflare/cloudflared#1783 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
orchestration.migration.data.tasks.retry values are ignored by the 8.8 data migration jobPossibly taken @irisfield claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
camunda/camunda-platform-helm#7773 ·
Maintainers usually reply within 1 day
-
Add missing unit tests for IsAdmissionPolicyName and IsCertManagerResourceNamePossibly taken @a1h8 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
kubernetes-sigs/security-profiles-operator#3644 ·
Maintainers usually reply within 1 day