TestReconcile_LicenseRotationUploadsNewSecretValue fails at -count=3 (reuses a control plane name)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 62/100
Research direction
The failing test is TestReconcile_LicenseRotationUploadsNewSecretValue at line 895 of internal/controller/codercontrolplane_controller_test.go. Start by reading how it names its CoderControlPlane and how its cleanup removes that object in envtest. Reproduce with GOFLAGS=-mod=vendor go test ./internal/controller/ -run 'TestReconcile_LicenseRotationUploadsNewSecretValue$' -count=3. Done means the repeated run passes, and the name or wait-for-deletion fix should not change the test's assertions.
Written by the indexing model from the issue text.
Description
Summary
TestReconcile_LicenseRotationUploadsNewSecretValue (internal/controller/codercontrolplane_controller_test.go:895) fails when run with -count=3. It reuses a fixed CoderControlPlane name, and a later run starts before envtest has removed the object from the earlier run.
Reproduce
GOFLAGS=-mod=vendor go test ./internal/controller/ -run 'TestReconcile_LicenseRotationUploadsNewSecretValue$' -count=3
The #156 worker reported this while it ran repeated tests for #316. I did not reproduce it myself.
Fix
Give each run a unique name (for example a suffix from t.Name() plus a counter or random string), or wait until the object is gone in cleanup. CI runs each test once, so CI is not affected today.
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: medium
- Dominant language
- Go
- Stars
- 5
- Forks
- 3
- Avg merge
- 2h 56m
- Merged PRs (30d)
- 163
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from coder/coder-k8s
-
🤖 verification skills: harden check.sh and verify.sh argument and file handling (#391 follow-ups)Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
CoderWorkspacePoolMember checkCreate: trust only Coder's own 404 on the name lookup (before PR 12)Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
CoderMCPServer Kind E2E follow-upsPossibly taken @ThomasK33 claimed this 15 days ago. Open
coder/coder-k8s#390 · 1 assignee ·
Maintainers usually reply within 1 day
-
CoderMCPServer delete and RBAC test follow-upsPossibly taken @ThomasK33 claimed this 15 days ago. Open
coder/coder-k8s#378 · 1 assignee ·
Maintainers usually reply within 1 day
-
Ownership proof for Coder IDs recorded in controller status (D11 B)Possibly taken @ThomasK33 claimed this 15 days ago. Open
coder/coder-k8s#372 · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
orchestration.migration.data.tasks.retry values are ignored by the 8.8 data migration jobPossibly taken @irisfield claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
camunda/camunda-platform-helm#7773 ·
Maintainers usually reply within 1 day
-
Add missing unit tests for IsAdmissionPolicyName and IsCertManagerResourceNamePossibly taken @a1h8 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
kubernetes-sigs/security-profiles-operator#3644 ·
Maintainers usually reply within 1 day
-
[Bug]: Anthropic Responses converter forwards empty text blocks, upstream rejects with 400Possibly taken @david-choi-querypie claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
[DOCS]: enforce_admins description understates what it covers and omits push restrictionsPossibly taken @dav-tb claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 78/100
integrations/terraform-provider-github#3707 · 1 comment ·
Maintainers usually reply within 1 day