Adapter Interface should not enforce constructor
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 45/100
Research direction
Start with src/Adapter/Adapter.php around line 26 and read the Adapter interface and its constructor declaration. Done means the interface no longer enforces an implementation-specific constructor; check the repository's adapter implementations for compatibility and run the relevant test suite if available.
Written by the indexing model from the issue text.
Description
https://github.com/cloudflare/cloudflare-php/blob/master/src/Adapter/Adapter.php#L26
interface Adapter
{
/**
* Adapter constructor.
*
* @param Auth $auth
* @param string $baseURI
*/
public function __construct(Auth $auth, string $baseURI);
An interface should not enforce any constructor as this is an implementation-issue
- Dominant language
- PHP
- Stars
- 674
- Forks
- 268
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cloudflare/cloudflare-php
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
cloudflare/cloudflare-php#202 · 1 reaction ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
cloudflare/cloudflare-php#156 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
cloudflare/cloudflare-php#278 · 5 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
cloudflare/cloudflare-php#272 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
cloudflare/cloudflare-php#264 ·
All issues in cloudflare/cloudflare-php
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
filamentphp/filament#20630 ·
Maintainers usually reply within 1 day
-
Issue: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
OpenAPITools/openapi-generator#25107 ·
Maintainers usually reply within 1 day
-
needs-maintainer-review review:approve
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Ultimate-Multisite/ultimate-ai-connector-compatible-endpoints#163 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day