setEmailObfuscation have wrong configuration id.

Open Beginner friendly
#156 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
php
Domain
api

Research direction

Open cloudflare-php/src/Configurations/PageRulesActions.php at line 129 and inspect setEmailObfuscation. Verify that the configuration identifier used there is the one named in the issue, email_obfuscation, rather than disable_security. Done means the method uses the correct identifier.

Written by the indexing model from the issue text.

Description

setEmailObfuscation have the id of disable_security

cloudflare-php/src/Configurations/PageRulesActions.php

LINE:129

    public function setEmailObfuscation(bool $active)
    {
        $this->addConfigurationOption('disable_security', [
            'value' => $this->getBoolAsOnOrOff($active)
        ]);
    }

It should be

$this->addConfigurationOption('email_obfuscation', [

Thanks.

Dominant language
PHP
Stars
674
Forks
268
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cloudflare/cloudflare-php

All issues in cloudflare/cloudflare-php

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.