`signIn.sso()` (Future API) silently does nothing for OAuth when a SignIn already exists
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 58/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- next.js, react, typescript
- Domain
- authentication, frontend
Research direction
Start in packages/clerk-js/src/core/resources/SignIn.ts and read SignInFuture.sso, focusing on how shouldCreateSignIn handles an existing sign-in for OAuth strategies. Reproduce with the component and steps in the issue, then verify that sso() starts OAuth or returns a meaningful error when a sign-in already has an id. The issue does not name a test file.
Written by the indexing model from the issue text.
Description
Preliminary Checks
- I have reviewed the documentation: https://clerk.com/docs
- I have searched for existing issues: https://github.com/clerk/javascript/issues
- I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)
- This issue is not a question, general help request, or anything other than a bug report directly related to Clerk.
Reproduction
No public repository. Minimal component below (Next.js App Router, Future API). Happy to put together a repo if that helps.
Publishable key
Development instance, available on request.
Description
Related to #9006, but the trigger is different: no reset() is involved, and the button stays inert across page reloads.
With the Future API (useSignIn() from @clerk/nextjs, not /legacy), signIn.sso({ strategy: 'oauth_google', ... }) resolves with { error: null } without sending any request and without navigating, as soon as the client already holds a SignIn that has an id and no pending external redirect. A failed attempt with an unknown identifier is enough to get there. Since that sign-in lives on the client, it survives page reloads: "Continue with Google" stays dead for that browser until the sign-in goes away.
Steps to reproduce:
'use client';
import { useSignIn } from '@clerk/nextjs';
export default function Page() {
const { signIn } = useSignIn();
return (
<>
<button onClick={() => signIn?.create({ identifier: '[email protected]' })}>
1. Attempt with an unknown identifier
</button>
<button
onClick={async () => {
const { error } = await signIn!.sso({
strategy: 'oauth_google',
redirectUrl: '/',
redirectCallbackUrl: `${window.location.origin}/sso-callback`,
});
console.log('sso resolved', { error, id: signIn!.id, status: signIn!.status });
}}
>
2. Continue with Google
</button>
</>
);
}
- Click 1. The attempt fails with
form_identifier_not_found, and the client now holds aSignIn(sia_…) with statusneeds_identifier. In our app we first ran into it after a failedsignIn.password(). - Click 2.
- Optionally reload the page and click 2 again: same result.
Expected behavior:
sso() starts a new OAuth attempt and navigates to the provider, or at least resolves with an error saying why it can't.
Actual behavior:
sso() resolves with { error: null }. No request is sent to the Frontend API, nothing navigates, and signIn.id is unchanged.
Root cause (clerk-js 6.41.0, unchanged on main / 6.42.3), in SignInFuture.sso (packages/clerk-js/src/core/resources/SignIn.ts):
const hasPendingRedirect = !!this.#resource.firstFactorVerification.externalVerificationRedirectURL;
const wouldReplayStaleRedirect = strategy !== 'enterprise_sso' && hasPendingRedirect;
const shouldCreateSignIn = !this.#resource.id || wouldReplayStaleRedirect;
When the sign-in already has an id and no external redirect URL, shouldCreateSignIn is false. For oauth_* strategies nothing else runs afterwards (prepare_first_factor is only called for enterprise_sso), so pendingHandOff() returns null and the method returns without doing anything. The classic authenticateWithRedirect doesn't have this problem, since it creates a new sign-in unless continueSignIn is set.
Workaround without internals: when signIn.id is set, call signIn.reset(), then call sso() from an effect on the fresh signIn the hook returns on the next render. In 6.41.0 the reset does reach the hook on the next render; it just can't be used inside the same handler, which is #9006.
Possible fixes:
- create a new sign-in for
oauth_*strategies when reusing the existing one would not produce a redirect, or - resolve with an
errorinstead of a silent no-op.
Environment
@clerk/nextjs: 7.3.2
@clerk/react: 6.6.1
@clerk/shared: 4.10.1
@clerk/clerk-js: 6.41.0 (loaded from the Frontend API)
next: 15.5.18
react: 18.2.0
OS: macOS; browser: Chromium-based
- Dominant language
- TypeScript
- Stars
- 1.8k
- Forks
- 492
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 374
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from clerk/javascript
-
<SignIn />: the reset password code step renders an empty, focusable back button with no accessible namePossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
clerk/javascript#10708 ·
Maintainers usually reply within 1 day
-
Built-in reverification dialog lacks an accessible name (aria-dialog-name)Possibly taken @ItsShivam05 claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
clerk/javascript#10548 ·
Maintainers usually reply within 1 day
-
MFA enrollment QR SVG lacks an accessible name (svg-img-alt)Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
clerk/javascript#10547 ·
Maintainers usually reply within 1 day
-
<SignIn />: first "Use email" click switches back to phone when `initialValues.phoneNumber` is setPossibly taken @twicestruck claimed this 22 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
clerk/javascript#10487 ·
Maintainers usually reply within 1 day
-
useLoadedIsomorphicClerk misses "ready" when a ClerkProvider remounts after clerk-js has loaded — <ClerkLoading> never resolvesMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
clerk/javascript#10462 ·
Maintainers usually reply within 1 day
All issues in clerk/javascript
Similar issues
-
`@angular/[email protected]` depends on vulnerable Vite 7.3.7 - GHSA-p4f5-76q4-ffq7 (Critical RCE)Openarea: @angular/build
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
angular/angular-cli#34764 ·
Maintainers usually reply within 1 day
-
status/need-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
google-gemini/gemini-cli#30384 · 1 comment ·
Maintainers usually reply within 1 day
-
P2
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug ready-for-human
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
LucasSantana-Dev/Lucky#3150 ·
Maintainers usually reply within 1 day
-
enhancement good first issue priority: low size: XS
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day