Unhealthy code style
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- tooling
Research direction
Locate the nonZero function shown in the issue and inspect nearby loop-style conventions before deciding whether the proposed change fits the project. Compare the current and proposed forms for equivalent behavior, then verify the chosen style without changing the function's output.
Written by the indexing model from the issue text.
Description
I've found you are always prevent to use for loop but for loop is better than while loop in case of determined loop steps. It's more reliable.
E.g:
function nonZero (len) {
var out = Buffer.allocUnsafe(len)
var i = 0
var cache = randomBytes(len * 2)
var cur = 0
var num
while (i < len) {
if (cur === cache.length) {
cache = randomBytes(len * 2)
cur = 0
}
num = cache[cur++]
if (num) {
out[i++] = num
}
}
return out
}
Could be:
function nonZero (len) {
var out = Buffer.allocUnsafe(len)
var cache = randomBytes(len * 2)
var num
for ( var i = 0, cur = 0; i < len; i++) {
if (cur === cache.length) {
cache = randomBytes(len * 2)
cur = 0
}
num = cache[cur++]
if (num) {
out[i] = num
}
}
return out
}
- Dominant language
- JavaScript
- Stars
- 28
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from browserify/publicEncrypt
-
Difficulty 2/5 1-3 hours Newbie friendliness 30/100
browserify/publicEncrypt#25 ·
All issues in browserify/publicEncrypt
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
TheOdinProject/curriculum#31444 ·
Maintainers usually reply within 1 day
-
software-development-practices software-development-practices:nist-ssdf
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
githubnext/gh-aw-cao#15860 ·
Maintainers usually reply within 1 day
-
framework/gatsby help wanted kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 87/100
Maintainers usually reply within 2 days
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
PedestrianDynamics/pyFDS-Evac#476 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
aiko-chan-ai/DiscordBotClient#380 ·