Provide more explicit capture of error from PoolListHandler.get given unknown pool type?
@charles-cowart is already working on this.
Since Jul 20, 2019.
Assessment
This issue has not been assessed yet.
Description
Currently, PoolListHandler.get throws a 500 error if it is passed a pool type that it doesn't recognize. This is as it should be :) However, one of the places this get is used is within an ajax call in sequencing.html:
At the moment there is no handling in place for errors from this ajax call, so if the 500 error is encountered, it is not handled and the code just keeps running. This leads to a cryptic error later in which the DataTable cannot be created because no results were returned from the ajax call:
At least the user can't make a garbage output, but clearly we could do better here.
This issue should be addressed before adding any new protocols to the software (as those could lead to new pool types). Related to #509 Centralize and harden identification of pool component types and probably to #510 PoolListHandler.get would identify pools from future new protocols as amplicon sequencing pools . Similar to #405 Silent 500 errors when plating samples.
- Dominant language
- Python
- Stars
- 2
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from biocore/LabControl
-
bug front-end question
Difficulty 4/5 3-5 days Newbie friendliness 30/100
biocore/LabControl#594 ·
-
front-end question
Difficulty 5/5 Over a week Newbie friendliness 35/100
biocore/LabControl#593 ·
-
Cache list of active samples when the active study is changed in the plating interfaceMay be free again @fedarko claimed this 2575 days ago, and no pull request is open. Openfront-end
biocore/LabControl#592 · 1 assignee ·
-
code refactor front-end
Difficulty 5/5 Over a week Newbie friendliness 25/100
biocore/LabControl#591 ·
-
priority:low
Difficulty 3/5 1-2 days Newbie friendliness 20/100
biocore/LabControl#590 ·
All issues in biocore/LabControl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
PedestrianDynamics/pyFDS-Evac#343 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
theskumar/python-dotenv#708 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 2 days
-
Docs Timedelta
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pandas-dev/pandas#69919 ·
Maintainers usually reply within 1 day
-
API documentation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
zephyrproject-rtos/west#1009 · 2 comments ·
Maintainers usually reply within 3 days