Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Provide more explicit capture of error from PoolListHandler.get given unknown pool type?

Open
#512 2 comments 0 reactions 3 assignees View on GitHub

@charles-cowart is already working on this.

Since Jul 20, 2019.

Assessment

This issue has not been assessed yet.

Description

Currently, PoolListHandler.get throws a 500 error if it is passed a pool type that it doesn't recognize. This is as it should be :) However, one of the places this get is used is within an ajax call in sequencing.html:

https://github.com/jdereus/labman/blob/46241e448edd4fc615aeea914e8dd80bf88aad79/labcontrol/gui/templates/sequencing.html#L100-L108

At the moment there is no handling in place for errors from this ajax call, so if the 500 error is encountered, it is not handled and the code just keeps running. This leads to a cryptic error later in which the DataTable cannot be created because no results were returned from the ajax call:

Screen Shot 2019-05-06 at 4 54 01 PM

At least the user can't make a garbage output, but clearly we could do better here.

This issue should be addressed before adding any new protocols to the software (as those could lead to new pool types). Related to #509 Centralize and harden identification of pool component types and probably to #510 PoolListHandler.get would identify pools from future new protocols as amplicon sequencing pools . Similar to #405 Silent 500 errors when plating samples.

Dominant language
Python
Stars
2
Forks
15
PR merge metrics
No merged PRs in 30d

Getting set up

We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from biocore/LabControl

All issues in biocore/LabControl

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.