Charts: setting `valueAxis` skips theme styling of axis labels and axis lines
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 67/100
Research direction
Start with _add_chart in sdpm/sdpm/engine/builder/elements/chart.py and read how valueAxis, categoryAxis, and _chartFingerprint distinguish edited imports from hand-written JSON. Review tests/test_chart_roundtrip.py and add the stated case: a scale-only valueAxis should retain themed tick-label size and colour. Run the chart round-trip tests; done when the regression passes without changing styling restored for unedited PPTX charts.
Written by the indexing model from the issue text.
Description
What happened?
_add_chart (sdpm/sdpm/engine/builder/elements/chart.py) treats a chart that has valueAxis or categoryAxis as a round-tripped chart (if not val_axis_def and not cat_axis_def:). For such a chart it skips:
- tick label font size, colour and font (
tick_font_size,text_muted,fonts["halfwidth"]) - the subtle axis line colour and width
- the title colour (
elif not elem.get("valueAxis")) and the data label font
So a chart written by an agent that only sets the scale ("valueAxis": {"min": 0, "max": 5, "majorUnit": 1}) gets the default chart text: large, without the theme colour or font, with default tick marks. The same chart without valueAxis gets 10pt muted labels in the template font.
This affects bar, line and radar. It matters most for radar (#623): its guide recommends valueAxis so the rings match the scoring scale, so most radar charts take this path. Rendering the chart-radar guide's example on blank-dark shows white labels at the default size and white cross tick marks on every spoke. Removing valueAxis gives themed labels.
Expected
Setting the axis scale should not turn off theme styling. Only a chart read back from a PPTX should keep the styling it came with.
Notes for the fix
- Round-tripped charts are now told apart by
_chartFingerprint. An unedited one restores_chartXmland never reaches this code, so this code path only runs for an edited import or for JSON written by hand or by an agent. --minimalJSON (sdpm/sdpm/engine/schema/minimal.py) drops every_key, including_chartFingerprintand_chartFontSize. Decide what a minimal round trip should look like before choosing the new condition.- Tests:
tests/test_chart_roundtrip.py. Add a case wherevalueAxiswith onlymin/max/majorUnitstill gets the themed tick label font size and colour.
Version
main at a44c66a3 (plus #623 for the radar case)
- Dominant language
- Python
- Stars
- 136
- Forks
- 13
- Avg merge
- 7h 43m
- Merged PRs (30d)
- 180
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aws-samples/sample-spec-driven-presentation-maker
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
aws-samples/sample-spec-driven-presentation-maker#648 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
aws-samples/sample-spec-driven-presentation-maker#646 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 50/100
aws-samples/sample-spec-driven-presentation-maker#627 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 4/5 3-5 days Newbie friendliness 68/100
aws-samples/sample-spec-driven-presentation-maker#622 ·
Maintainers usually reply within 1 day
-
Charts: add radar charts (chartType "radar")Possibly taken @tridev-tej claimed this 4 days ago. Openenhancement good first issue
Difficulty 4/5 3-5 days Newbie friendliness 25/100
aws-samples/sample-spec-driven-presentation-maker#621 ·
Maintainers usually reply within 1 day
All issues in aws-samples/sample-spec-driven-presentation-maker
Similar issues
-
firestore: enable live window.yaml pipeline system tests once add_window_fields is in productionOpen
Difficulty 1/5 Under an hour Newbie friendliness 64/100
googleapis/google-cloud-python#19115 ·
Maintainers usually reply within 2 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug prov-json
Difficulty 2/5 1-3 hours Newbie friendliness 87/100
Maintainers usually reply within 1 day