Charts: setting `valueAxis` skips theme styling of axis labels and axis lines

Open
#630 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@ShotaroKataoka is already working on this.

Since Nov 16, 2026.

  • #645 by @ShotaroKataoka — open

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
67/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
backend

Research direction

Start with _add_chart in sdpm/sdpm/engine/builder/elements/chart.py and read how valueAxis, categoryAxis, and _chartFingerprint distinguish edited imports from hand-written JSON. Review tests/test_chart_roundtrip.py and add the stated case: a scale-only valueAxis should retain themed tick-label size and colour. Run the chart round-trip tests; done when the regression passes without changing styling restored for unedited PPTX charts.

Written by the indexing model from the issue text.

Description

bug
What happened?

_add_chart (sdpm/sdpm/engine/builder/elements/chart.py) treats a chart that has valueAxis or categoryAxis as a round-tripped chart (if not val_axis_def and not cat_axis_def:). For such a chart it skips:

  • tick label font size, colour and font (tick_font_size, text_muted, fonts["halfwidth"])
  • the subtle axis line colour and width
  • the title colour (elif not elem.get("valueAxis")) and the data label font

So a chart written by an agent that only sets the scale ("valueAxis": {"min": 0, "max": 5, "majorUnit": 1}) gets the default chart text: large, without the theme colour or font, with default tick marks. The same chart without valueAxis gets 10pt muted labels in the template font.

This affects bar, line and radar. It matters most for radar (#623): its guide recommends valueAxis so the rings match the scoring scale, so most radar charts take this path. Rendering the chart-radar guide's example on blank-dark shows white labels at the default size and white cross tick marks on every spoke. Removing valueAxis gives themed labels.

Expected

Setting the axis scale should not turn off theme styling. Only a chart read back from a PPTX should keep the styling it came with.

Notes for the fix
  • Round-tripped charts are now told apart by _chartFingerprint. An unedited one restores _chartXml and never reaches this code, so this code path only runs for an edited import or for JSON written by hand or by an agent.
  • --minimal JSON (sdpm/sdpm/engine/schema/minimal.py) drops every _ key, including _chartFingerprint and _chartFontSize. Decide what a minimal round trip should look like before choosing the new condition.
  • Tests: tests/test_chart_roundtrip.py. Add a case where valueAxis with only min/max/majorUnit still gets the themed tick label font size and colour.
Version

main at a44c66a3 (plus #623 for the radar case)

Dominant language
Python
Stars
136
Forks
13
Avg merge
7h 43m
Merged PRs (30d)
180

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aws-samples/sample-spec-driven-presentation-maker

All issues in aws-samples/sample-spec-driven-presentation-maker

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.