Charts: setting `valueAxis` skips theme styling of axis labels and axis lines
维护者通常 1 天内回复
评估
调研方向
Start with _add_chart in sdpm/sdpm/engine/builder/elements/chart.py and read how valueAxis, categoryAxis, and _chartFingerprint distinguish edited imports from hand-written JSON. Review tests/test_chart_roundtrip.py and add the stated case: a scale-only valueAxis should retain themed tick-label size and colour. Run the chart round-trip tests; done when the regression passes without changing styling restored for unedited PPTX charts.
由索引模型根据 Issue 内容生成。
描述
What happened?
_add_chart (sdpm/sdpm/engine/builder/elements/chart.py) treats a chart that has valueAxis or categoryAxis as a round-tripped chart (if not val_axis_def and not cat_axis_def:). For such a chart it skips:
- tick label font size, colour and font (
tick_font_size,text_muted,fonts["halfwidth"]) - the subtle axis line colour and width
- the title colour (
elif not elem.get("valueAxis")) and the data label font
So a chart written by an agent that only sets the scale ("valueAxis": {"min": 0, "max": 5, "majorUnit": 1}) gets the default chart text: large, without the theme colour or font, with default tick marks. The same chart without valueAxis gets 10pt muted labels in the template font.
This affects bar, line and radar. It matters most for radar (#623): its guide recommends valueAxis so the rings match the scoring scale, so most radar charts take this path. Rendering the chart-radar guide's example on blank-dark shows white labels at the default size and white cross tick marks on every spoke. Removing valueAxis gives themed labels.
Expected
Setting the axis scale should not turn off theme styling. Only a chart read back from a PPTX should keep the styling it came with.
Notes for the fix
- Round-tripped charts are now told apart by
_chartFingerprint. An unedited one restores_chartXmland never reaches this code, so this code path only runs for an edited import or for JSON written by hand or by an agent. --minimalJSON (sdpm/sdpm/engine/schema/minimal.py) drops every_key, including_chartFingerprintand_chartFontSize. Decide what a minimal round trip should look like before choosing the new condition.- Tests:
tests/test_chart_roundtrip.py. Add a case wherevalueAxiswith onlymin/max/majorUnitstill gets the themed tick label font size and colour.
Version
main at a44c66a3 (plus #623 for the radar case)
- 主要语言
- Python
- 星标
- 136
- 派生
- 13
- 平均合并
- 7 小时 36 分钟
- 30 天内合并 PR
- 175
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
aws-samples/sample-spec-driven-presentation-maker 的其他 Issue
-
enhancement
难度 4/5 3-5 天 新手友好度 50/100
aws-samples/sample-spec-driven-presentation-maker#627 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 4/5 3-5 天 新手友好度 68/100
aws-samples/sample-spec-driven-presentation-maker#622 ·
维护者通常 1 天内回复
-
Charts: add radar charts (chartType "radar")可能已有人在做 @tridev-tej 于 4 天前认领。 未关闭enhancement good first issue
难度 4/5 3-5 天 新手友好度 25/100
aws-samples/sample-spec-driven-presentation-maker#621 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 3/5 1-2 天 新手友好度 77/100
aws-samples/sample-spec-driven-presentation-maker#620 ·
维护者通常 1 天内回复
-
Make the element JSON round trip match the docs (4 small fixes)可能已有人在做 @Vedant-200 于 5 天前认领。 未关闭enhancement good first issue
难度 3/5 1-2 天 新手友好度 35/100
aws-samples/sample-spec-driven-presentation-maker#586 ·
维护者通常 1 天内回复
查看 aws-samples/sample-spec-driven-presentation-maker 的全部 Issue
相似的 Issue
-
难度 1/5 1-3 小时 新手友好度 76/100
samuelclay/NewsBlur#2214 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
MODEL_NOT_FOUND gives no suggestion for a model listed only as model:profile可能已有人在做 @ShaiShmuel 今天认领。 未关闭enhancement rust
难度 2/5 1-3 小时 新手友好度 65/100
superlinked/sie#985 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
readthedocs/readthedocs-builder#73 ·
维护者通常 1 天内回复