Charts: add scatter charts (chartType "scatter")
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 68/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- python
- Domain
- data-visualization
Research direction
Start with _add_chart in sdpm/sdpm/engine/builder/elements/chart.py and the named chart round-trip tests in tests/test_chart_roundtrip.py; check how chart data and series colors are currently built. Then trace chart extraction in sdpm/sdpm/engine/converter/chart.py and scatter validation in sdpm/sdpm/engine/schema/lint.py. Done when the listed scatter round-trip, lint, and edit-rebuild cases pass, along with make lint and uv run pytest tests/test_chart_roundtrip.py -v.
Written by the indexing model from the issue text.
Description
What problem would this solve?
Native charts support chartType bar, line, pie and donut only, and all of them plot values against categories. A scatter chart plots two numeric variables against each other (latency vs. payload size, cost vs. throughput, before/after benchmarks), which a category chart cannot show. python-pptx builds scatter charts natively (XL_CHART_TYPE.XY_SCATTER with XyChartData). Today a chartType: "scatter" silently becomes a bar chart (see TestInvalidInput::test_unknown_chart_type_degrades_to_bar).
Proposed solution
Add chartType: "scatter". Its series carry points ([x, y] pairs) instead of values, and it takes no categories:
{
"type": "chart", "chartType": "scatter",
"x": 192, "y": 216, "width": 1536, "height": 700,
"series": [
{"name": "Lambda", "points": [[128, 45], [256, 30], [512, 22], [1024, 18]], "color": "#FF9900"},
{"name": "Fargate", "points": [[128, 60], [512, 35], [1024, 25]], "color": "#41B3FF"}
],
"legend": true,
"valueAxis": {"min": 0},
"title": "Latency (ms) by memory (MB)"
}
- Markers only (
XL_CHART_TYPE.XY_SCATTER); seriescoloris the marker colour;style.markerSizeapplies. Connecting lines (XY_SCATTER_LINES*,XY_SCATTER_SMOOTH*) are out of scope for this issue. valueAxisapplies to the Y axis as it does today. X-axis options can come in a follow-up; keep the default X axis in this issue.
Files to touch:
sdpm/sdpm/engine/builder/elements/chart.py(_add_chart): build the data withXyChartData(add_series(name)thenseries.add_data_point(x, y)) whenchartTypeisscatter, add it to thetype_map, and colour the series markers. The current code always buildsCategoryChartDataand generates placeholder categories, so this is the main change.sdpm/sdpm/engine/converter/chart.py(extract_chart_element): mapXY_SCATTERintype_mapand read each series' points. python-pptx'sseries.valuesgives the Y values only; read X from the series'c:xValelement. Writepoints, notcategories/values.sdpm/sdpm/engine/schema/lint.py: addscatterto_CHART_TYPES, update the "Specify bar, line, pie, or donut" message, skip the categories/values length check for scatter, and flag a scatter series withoutpoints.- Docs: the chart section of
sdpm/references/guides/slide-json-media.md(chartTypelist, thepointsshape, guide list), and a newsdpm/references/guides/chart-scatter.mdmodelled onchart-line.md. If you add the guide, also add it next tochart-bar/chart-line/chart-pieinsdpm/references/guides/slide-json-spec.mdandsdpm/references/workflows/composer.md. CHANGELOG.md: an entry under[Unreleased]→Added.
Done when
-
chartType: "scatter"builds ac:scatterChart, andpptx_to_jsonreads it back aschartType: "scatter"with series names,points(in order) and colours intact. - An edited scatter chart (a changed point) is rebuilt from its JSON, not restored from
_chartXml. -
TestInvalidInput::test_unknown_chart_type_degrades_to_baruses another unknown type name instead ofscatter. - Lint accepts
scatterand still rejects unknown types. -
make lintanduv run pytest tests/test_chart_roundtrip.py -vpass.
Tests to copy: TestChartTypes::test_line_markers, TestSeriesAndCategories::test_non_ascii_and_float_values and TestColors::test_line_series_color in tests/test_chart_roundtrip.py (they use _one_chart / _built_chart, no LibreOffice needed).
Which area?
Slide generation / engine (layouts, elements, charts)
🤖 Created by Kiro Crew
- Dominant language
- Python
- Stars
- 136
- Forks
- 13
- Avg merge
- 7h 43m
- Merged PRs (30d)
- 180
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aws-samples/sample-spec-driven-presentation-maker
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
aws-samples/sample-spec-driven-presentation-maker#648 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
aws-samples/sample-spec-driven-presentation-maker#646 ·
Maintainers usually reply within 1 day
-
Charts: setting `valueAxis` skips theme styling of axis labels and axis linesPossibly taken @ShotaroKataoka claimed this 1 day ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 67/100
aws-samples/sample-spec-driven-presentation-maker#630 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 50/100
aws-samples/sample-spec-driven-presentation-maker#627 ·
Maintainers usually reply within 1 day
-
Charts: add radar charts (chartType "radar")Possibly taken @tridev-tej claimed this 4 days ago. Openenhancement good first issue
Difficulty 4/5 3-5 days Newbie friendliness 25/100
aws-samples/sample-spec-driven-presentation-maker#621 ·
Maintainers usually reply within 1 day
All issues in aws-samples/sample-spec-driven-presentation-maker
Similar issues
-
firestore: enable live window.yaml pipeline system tests once add_window_fields is in productionOpen
Difficulty 1/5 Under an hour Newbie friendliness 64/100
googleapis/google-cloud-python#19115 ·
Maintainers usually reply within 2 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug prov-json
Difficulty 2/5 1-3 hours Newbie friendliness 87/100
Maintainers usually reply within 1 day