Charts: add scatter charts (chartType "scatter")
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 68/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- python
- Área
- data-visualization
Línea de trabajo
Start with _add_chart in sdpm/sdpm/engine/builder/elements/chart.py and the named chart round-trip tests in tests/test_chart_roundtrip.py; check how chart data and series colors are currently built. Then trace chart extraction in sdpm/sdpm/engine/converter/chart.py and scatter validation in sdpm/sdpm/engine/schema/lint.py. Done when the listed scatter round-trip, lint, and edit-rebuild cases pass, along with make lint and uv run pytest tests/test_chart_roundtrip.py -v.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What problem would this solve?
Native charts support chartType bar, line, pie and donut only, and all of them plot values against categories. A scatter chart plots two numeric variables against each other (latency vs. payload size, cost vs. throughput, before/after benchmarks), which a category chart cannot show. python-pptx builds scatter charts natively (XL_CHART_TYPE.XY_SCATTER with XyChartData). Today a chartType: "scatter" silently becomes a bar chart (see TestInvalidInput::test_unknown_chart_type_degrades_to_bar).
Proposed solution
Add chartType: "scatter". Its series carry points ([x, y] pairs) instead of values, and it takes no categories:
{
"type": "chart", "chartType": "scatter",
"x": 192, "y": 216, "width": 1536, "height": 700,
"series": [
{"name": "Lambda", "points": [[128, 45], [256, 30], [512, 22], [1024, 18]], "color": "#FF9900"},
{"name": "Fargate", "points": [[128, 60], [512, 35], [1024, 25]], "color": "#41B3FF"}
],
"legend": true,
"valueAxis": {"min": 0},
"title": "Latency (ms) by memory (MB)"
}
- Markers only (
XL_CHART_TYPE.XY_SCATTER); seriescoloris the marker colour;style.markerSizeapplies. Connecting lines (XY_SCATTER_LINES*,XY_SCATTER_SMOOTH*) are out of scope for this issue. valueAxisapplies to the Y axis as it does today. X-axis options can come in a follow-up; keep the default X axis in this issue.
Files to touch:
sdpm/sdpm/engine/builder/elements/chart.py(_add_chart): build the data withXyChartData(add_series(name)thenseries.add_data_point(x, y)) whenchartTypeisscatter, add it to thetype_map, and colour the series markers. The current code always buildsCategoryChartDataand generates placeholder categories, so this is the main change.sdpm/sdpm/engine/converter/chart.py(extract_chart_element): mapXY_SCATTERintype_mapand read each series' points. python-pptx'sseries.valuesgives the Y values only; read X from the series'c:xValelement. Writepoints, notcategories/values.sdpm/sdpm/engine/schema/lint.py: addscatterto_CHART_TYPES, update the "Specify bar, line, pie, or donut" message, skip the categories/values length check for scatter, and flag a scatter series withoutpoints.- Docs: the chart section of
sdpm/references/guides/slide-json-media.md(chartTypelist, thepointsshape, guide list), and a newsdpm/references/guides/chart-scatter.mdmodelled onchart-line.md. If you add the guide, also add it next tochart-bar/chart-line/chart-pieinsdpm/references/guides/slide-json-spec.mdandsdpm/references/workflows/composer.md. CHANGELOG.md: an entry under[Unreleased]→Added.
Done when
-
chartType: "scatter"builds ac:scatterChart, andpptx_to_jsonreads it back aschartType: "scatter"with series names,points(in order) and colours intact. - An edited scatter chart (a changed point) is rebuilt from its JSON, not restored from
_chartXml. -
TestInvalidInput::test_unknown_chart_type_degrades_to_baruses another unknown type name instead ofscatter. - Lint accepts
scatterand still rejects unknown types. -
make lintanduv run pytest tests/test_chart_roundtrip.py -vpass.
Tests to copy: TestChartTypes::test_line_markers, TestSeriesAndCategories::test_non_ascii_and_float_values and TestColors::test_line_series_color in tests/test_chart_roundtrip.py (they use _one_chart / _built_chart, no LibreOffice needed).
Which area?
Slide generation / engine (layouts, elements, charts)
🤖 Created by Kiro Crew
- Lenguaje dominante
- Python
- Estrellas
- 136
- Forks
- 13
- Merge medio
- 7 h 36 min
- PR fusionados (30 d)
- 175
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de aws-samples/sample-spec-driven-presentation-maker
-
Charts: setting `valueAxis` skips theme styling of axis labels and axis linesPosiblemente ocupada @ShotaroKataoka la tomó hace 1 día. Abiertobug
Dificultad 3/5 1-2 días Aptitud para principiantes 67/100
aws-samples/sample-spec-driven-presentation-maker#630 ·
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 50/100
aws-samples/sample-spec-driven-presentation-maker#627 ·
Los mantenedores suelen responder en 1 día
-
Charts: add radar charts (chartType "radar")Posiblemente ocupada @tridev-tej la tomó hace 4 días. Abiertoenhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 25/100
aws-samples/sample-spec-driven-presentation-maker#621 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 3/5 1-2 días Aptitud para principiantes 77/100
aws-samples/sample-spec-driven-presentation-maker#620 ·
Los mantenedores suelen responder en 1 día
-
Make the element JSON round trip match the docs (4 small fixes)Posiblemente ocupada @Vedant-200 la tomó hace 5 días. Abiertoenhancement good first issue
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
aws-samples/sample-spec-driven-presentation-maker#586 ·
Los mantenedores suelen responder en 1 día
Todos los issues de aws-samples/sample-spec-driven-presentation-maker
Issues similares
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 76/100
samuelclay/NewsBlur#2214 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día
-
MODEL_NOT_FOUND gives no suggestion for a model listed only as model:profilePosiblemente ocupada @ShaiShmuel la tomó hoy. Abiertoenhancement rust
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
superlinked/sie#985 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
readthedocs/readthedocs-builder#73 ·
Los mantenedores suelen responder en 1 día