Charts: add scatter charts (chartType "scatter")

Abierto
#622 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
68/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python

Línea de trabajo

Start with _add_chart in sdpm/sdpm/engine/builder/elements/chart.py and the named chart round-trip tests in tests/test_chart_roundtrip.py; check how chart data and series colors are currently built. Then trace chart extraction in sdpm/sdpm/engine/converter/chart.py and scatter validation in sdpm/sdpm/engine/schema/lint.py. Done when the listed scatter round-trip, lint, and edit-rebuild cases pass, along with make lint and uv run pytest tests/test_chart_roundtrip.py -v.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement good first issue
What problem would this solve?

Native charts support chartType bar, line, pie and donut only, and all of them plot values against categories. A scatter chart plots two numeric variables against each other (latency vs. payload size, cost vs. throughput, before/after benchmarks), which a category chart cannot show. python-pptx builds scatter charts natively (XL_CHART_TYPE.XY_SCATTER with XyChartData). Today a chartType: "scatter" silently becomes a bar chart (see TestInvalidInput::test_unknown_chart_type_degrades_to_bar).

Proposed solution

Add chartType: "scatter". Its series carry points ([x, y] pairs) instead of values, and it takes no categories:

{
  "type": "chart", "chartType": "scatter",
  "x": 192, "y": 216, "width": 1536, "height": 700,
  "series": [
    {"name": "Lambda", "points": [[128, 45], [256, 30], [512, 22], [1024, 18]], "color": "#FF9900"},
    {"name": "Fargate", "points": [[128, 60], [512, 35], [1024, 25]], "color": "#41B3FF"}
  ],
  "legend": true,
  "valueAxis": {"min": 0},
  "title": "Latency (ms) by memory (MB)"
}
  • Markers only (XL_CHART_TYPE.XY_SCATTER); series color is the marker colour; style.markerSize applies. Connecting lines (XY_SCATTER_LINES*, XY_SCATTER_SMOOTH*) are out of scope for this issue.
  • valueAxis applies to the Y axis as it does today. X-axis options can come in a follow-up; keep the default X axis in this issue.

Files to touch:

  • sdpm/sdpm/engine/builder/elements/chart.py (_add_chart): build the data with XyChartData (add_series(name) then series.add_data_point(x, y)) when chartType is scatter, add it to the type_map, and colour the series markers. The current code always builds CategoryChartData and generates placeholder categories, so this is the main change.
  • sdpm/sdpm/engine/converter/chart.py (extract_chart_element): map XY_SCATTER in type_map and read each series' points. python-pptx's series.values gives the Y values only; read X from the series' c:xVal element. Write points, not categories / values.
  • sdpm/sdpm/engine/schema/lint.py: add scatter to _CHART_TYPES, update the "Specify bar, line, pie, or donut" message, skip the categories/values length check for scatter, and flag a scatter series without points.
  • Docs: the chart section of sdpm/references/guides/slide-json-media.md (chartType list, the points shape, guide list), and a new sdpm/references/guides/chart-scatter.md modelled on chart-line.md. If you add the guide, also add it next to chart-bar / chart-line / chart-pie in sdpm/references/guides/slide-json-spec.md and sdpm/references/workflows/composer.md.
  • CHANGELOG.md: an entry under [Unreleased] → Added.

Done when

  • chartType: "scatter" builds a c:scatterChart, and pptx_to_json reads it back as chartType: "scatter" with series names, points (in order) and colours intact.
  • An edited scatter chart (a changed point) is rebuilt from its JSON, not restored from _chartXml.
  • TestInvalidInput::test_unknown_chart_type_degrades_to_bar uses another unknown type name instead of scatter.
  • Lint accepts scatter and still rejects unknown types.
  • make lint and uv run pytest tests/test_chart_roundtrip.py -v pass.

Tests to copy: TestChartTypes::test_line_markers, TestSeriesAndCategories::test_non_ascii_and_float_values and TestColors::test_line_series_color in tests/test_chart_roundtrip.py (they use _one_chart / _built_chart, no LibreOffice needed).

Which area?

Slide generation / engine (layouts, elements, charts)

🤖 Created by Kiro Crew

Lenguaje dominante
Python
Estrellas
136
Forks
13
Merge medio
7 h 36 min
PR fusionados (30 d)
175

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de aws-samples/sample-spec-driven-presentation-maker

Todos los issues de aws-samples/sample-spec-driven-presentation-maker

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.