JSON Schema: possible incompatibilities when plugging symfony/json-schema
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 8/100
Research direction
This is a design survey, not a single fix. Start with ShortNameDefinitionPolicy, DefinitionPolicyInterface, SchemaDocument and DefinitionProcessorInterface, which the issue names as the points where the output would diverge. Done means agreeing which differences API Platform will accept, which it will adapt through an extension point, and which need follow-up issues, with the decision recorded on this thread.
Written by the indexing model from the issue text.
Description
Description
Follow-up of #8696: what changes if api-platform/json-schema uses symfony/json-schema (https://github.com/symfony/symfony/pull/66685).
1. Dependency constraints
- The component first ships in Symfony 8.2 (its
CHANGELOG.md). - It requires PHP
>=8.4.1, API Platform requires PHP>=8.2. - It requires
symfony/type-info^7.4.6|^8.0.6, API Platform requires^7.4 || ^8.0.
2. Output changes with the default configuration
- JSON Schema output uses
$defsand#/$defs/instead ofdefinitionsand#/definitions/(Dialect::jsonSchema202012()). OpenAPI output keeps#/components/schemas/. $schemaishttps://json-schema.org/draft/2020-12/schemainstead ofhttp://json-schema.org/draft-07/schema#.- There is no Swagger 2.0 dialect. API Platform still has the deprecated
--spec-version=2export. - Definition names (
ShortNameDefinitionPolicy) put the format in aformat.<format>part instead of a.jsonldsuffix, append the direction (input/output), and have no.partial,.jsonMergePatchor_noidsuffix. Example:Dummy-read_format.jsonld_outputinstead ofDummy.jsonld-read. A customDefinitionPolicyInterfacecan produce other names. - With a direction, write-only properties are removed from output schemas and read-only properties from input schemas. API Platform keeps them, flagged
readOnly/writeOnly. The component only emits these flags without a direction. - Output schemas require properties that are always initialized (default value, promoted or constructor-set). Otherwise, mandatory constructor arguments are required. API Platform uses
ApiProperty::isRequired()(validation metadata or explicitrequired), with norequiredfor partial updates. callableandresourceproperties are removed. API Platform describes them astype: string.- Examples are
examples: [value]on JSON Schema 2020-12 and OpenAPI 3.1, andexampleonly on OpenAPI 3.0 (Dialect::example()). API Platform emitsexample. - Descriptions come from the PHPDoc. Values API Platform takes from metadata (
ApiPropertydescription,deprecated,externalDocsfromtypes, operation description) are not produced. - Ramsey
UuidInterfaceis not handled. API Platform describes it asformat: uuid.
3. Extension points
- The extension signatures have no operation or
ApiProperty. API Platform data has to go throughConfiguration::$context, which is neither part of the definition fingerprint nor of the default name. Any shape that depends on it (operation, partial update,gen_id) must be encoded in the name by a custom policy, or two shapes share one definition. SchemaDocument::reserve()anddefine()are@internal, and aDefinitionProcessorInterfacecan only change the definition it receives. Shared definitions such asHydraItemBaseSchemacannot be registered from an extension.- The root collection schema is not passed to any extension, so
hydra:member, JSON:APIdata/links/metaand HAL_embeddedstay in an outer decorator. - A
PropertySchemaProviderInterfacecan return user-defined schemas (ApiPropertyschema,jsonSchemaContext,openapiContext), but enrichers still run on top. API Platform leaves user-defined schemas untouched. - A definition is built for the first occurrence of a name, so shapes depending on the parent property (e.g.
gen_idon an embedded relation) collide: "a difference coming only from the parent cannot be detected and the first occurrence wins" (DefinitionPolicyInterface). - A
SchemaDocumentthrows when used with anotherrefPath, so JSON Schema (#/$defs/) and OpenAPI (#/components/schemas/) output cannot share one document.
Fits the existing extension points
- IRI references for non-embedded relations:
ClassSchemaResolverInterfacewithDefinitionParent. - Definition names:
DefinitionPolicyInterface. - Input/output DTOs: caller side.
- Validator constraints: built-in
ValidatorPropertySchemaEnricher. - Definitions shared across OpenAPI operations:
SchemaDocument,Dialect::openApi30()/openApi31(). - Eloquent models: the generator takes a
PropertyInfoExtractorInterface.
- Dominant language
- PHP
- Stars
- 2.6k
- Forks
- 989
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 100
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from api-platform/core
-
JSON:API: resource schemas (`*.jsonapi`) have `properties` but no `type: object`Possibly taken @ousamabenyounes claimed this 3 days ago. Open
Difficulty 2/5 Under an hour Newbie friendliness 80/100
api-platform/core#8701 ·
Maintainers usually reply within 1 day
-
JSON:API: `JsonApiCollectionBaseSchemaNoPagination` declares `data` as `type: array` without `items`Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
api-platform/core#8699 ·
Maintainers usually reply within 1 day
-
[Json-Schema] Nested resources lost externalDoc and description dataPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 3/5 1-2 days Newbie friendliness 68/100
api-platform/core#8721 ·
Maintainers usually reply within 1 day
-
JSON:API: 404/405 router errors are empty, and error objects have a non-spec `type` memberPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 3/5 1-2 days Newbie friendliness 50/100
api-platform/core#8704 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
api-platform/core#8703 ·
Maintainers usually reply within 1 day
All issues in api-platform/core
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/blocks-engine#3090 ·
Maintainers usually reply within 1 day
-
macOS
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
beyondcode/herd-community#1771 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
-
module: user interface priority: high severity: minor type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
[Enhancement] Add a dark-bg Tailwind variantPossibly taken @bd-viget claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
vigetlabs/wordpress-site-starter#306 ·
Maintainers usually reply within 1 day