JSON:API: 404/405 router errors are empty, and error objects have a non-spec `type` member
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 50/100
Research direction
Start with JsonApi\Serializer\ErrorNormalizer in src/JsonApi/Serializer and reproduce with the Novel resource from the issue. Compare the bodies of GET /nope, DELETE /novels/1 and GET /novels/999 to find where the non-operation errors lose their status, title and detail. Done when the 404 and 405 errors carry the same members as the operation errors, and no error object has a type member while links.type remains.
Written by the indexing model from the issue text.
Description
API Platform version(s) affected
4.4.4
Description
The JSON:API error documents have two problems that remain after #8366 (which makes status a string on main).
-
Errors that do not come from an operation are empty. An unknown route (404) or a method that is not allowed (405) answers with an error object that has only a generated
id. It has nostatus,titleordetail:{"errors":[{"id":"/.well-known/genid/1d2136a82a8b3a05d6a2"}]} -
Error objects have a
typemember. The spec lists the members of an error object (id,links,status,code,title,detail,source,meta), and "Unless otherwise noted, objects defined by this specification or any applied extensions MUST NOT contain any additional members."JsonApi\Serializer\ErrorNormalizercopies the problemtypetolinks.type, which is correct, but it also keeps it as atypemember:{"errors":[{"id":"/errors/404","title":"An error occurred","detail":"Not Found","status":404,"type":"/errors/404","links":{"type":"/errors/404"},"code":"404"}]}
#3042 is about the older problem+json format. These two problems are in the current errors format.
How to reproduce
#[ApiResource(operations: [
new Get(provider: [self::class, 'provide']),
new Post(processor: [self::class, 'process']),
])]
final class Novel
{
public int $id = 1;
public string $title = 'Dune';
public static function provide(): ?self { return null; }
public static function process(self $data, Operation $operation): self { return $data; }
}
| Request | Status | Body |
|---|---|---|
GET /nope |
404 | {"errors":[{"id":"/.well-known/genid/…"}]} |
DELETE /novels/1 |
405 | {"errors":[{"id":"/.well-known/genid/…"}]} |
GET /novels/999 |
404 | {"errors":[{"id":"/errors/404","title":"An error occurred","detail":"Not Found","status":404,"type":"/errors/404","links":{"type":"/errors/404"},"code":"404"}]} |
POST /novels with {"data":{"type":"Novel","attributes":{"title":5}}} |
400 | {"errors":[{"id":"/errors/400","title":"An error occurred","detail":"The type of the \"title\" attribute must be \"string\", \"integer\" given.","status":400,"type":"/errors/400","links":{"type":"/errors/400"},"code":"400"}]} |
Expected:
- The 404 and 405 errors have the same members as the other errors:
status,title,detail,codeandlinks.type. - Error objects have no
typemember. The value stays inlinks.type.
Additional Context
Checked on api-platform/core v4.4.4, Symfony 7.4, PHP 8.5, in an empty Symfony app. The related code in src/JsonApi/Serializer is the same on main, except for the error status cast (#8366).
The app has only FrameworkBundle, TwigBundle and ApiPlatformBundle, with this config:
$c->extension('api_platform', [
'mapping' => ['paths' => ['%kernel.project_dir%/src/ApiResource']],
'formats' => ['jsonapi' => ['application/vnd.api+json']],
'error_formats' => ['jsonapi' => ['application/vnd.api+json'], 'jsonproblem' => ['application/problem+json']],
'doctrine' => ['enabled' => false],
]);
All requests send Accept: application/vnd.api+json and, when they have a body, Content-Type: application/vnd.api+json. The responses are from the prod environment.
- Dominant language
- PHP
- Stars
- 2.6k
- Forks
- 989
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 100
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from api-platform/core
-
JSON:API: resource schemas (`*.jsonapi`) have `properties` but no `type: object`Possibly taken @ousamabenyounes claimed this 2 days ago. Open
Difficulty 2/5 Under an hour Newbie friendliness 80/100
api-platform/core#8701 ·
Maintainers usually reply within 1 day
-
JSON:API: `JsonApiCollectionBaseSchemaNoPagination` declares `data` as `type: array` without `items`Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
api-platform/core#8699 ·
Maintainers usually reply within 1 day
-
[Json-Schema] Nested resources lost externalDoc and description dataPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 3/5 1-2 days Newbie friendliness 68/100
api-platform/core#8721 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
api-platform/core#8703 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
api-platform/core#8702 ·
Maintainers usually reply within 1 day
All issues in api-platform/core
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
neos/flow-development-collection#3639 · 1 comment ·
Maintainers usually reply within 1 day
-
The PHP version check in prepare.php still allows PHP 7.2 and 7.3Possibly taken @ekamran claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
WordPress/phpunit-test-runner#359 ·
Maintainers usually reply within 2 days
-
ObjectMapper
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
symfony/symfony-docs#23390 ·
Maintainers usually reply within 2 days
-
sync-en
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 83/100
Maintainers usually reply within 3 days