JSON Schema: possible incompatibilities when plugging symfony/json-schema
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 8/100
Línea de trabajo
This is a design survey, not a single fix. Start with ShortNameDefinitionPolicy, DefinitionPolicyInterface, SchemaDocument and DefinitionProcessorInterface, which the issue names as the points where the output would diverge. Done means agreeing which differences API Platform will accept, which it will adapt through an extension point, and which need follow-up issues, with the decision recorded on this thread.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Description
Follow-up of #8696: what changes if api-platform/json-schema uses symfony/json-schema (https://github.com/symfony/symfony/pull/66685).
1. Dependency constraints
- The component first ships in Symfony 8.2 (its
CHANGELOG.md). - It requires PHP
>=8.4.1, API Platform requires PHP>=8.2. - It requires
symfony/type-info^7.4.6|^8.0.6, API Platform requires^7.4 || ^8.0.
2. Output changes with the default configuration
- JSON Schema output uses
$defsand#/$defs/instead ofdefinitionsand#/definitions/(Dialect::jsonSchema202012()). OpenAPI output keeps#/components/schemas/. $schemaishttps://json-schema.org/draft/2020-12/schemainstead ofhttp://json-schema.org/draft-07/schema#.- There is no Swagger 2.0 dialect. API Platform still has the deprecated
--spec-version=2export. - Definition names (
ShortNameDefinitionPolicy) put the format in aformat.<format>part instead of a.jsonldsuffix, append the direction (input/output), and have no.partial,.jsonMergePatchor_noidsuffix. Example:Dummy-read_format.jsonld_outputinstead ofDummy.jsonld-read. A customDefinitionPolicyInterfacecan produce other names. - With a direction, write-only properties are removed from output schemas and read-only properties from input schemas. API Platform keeps them, flagged
readOnly/writeOnly. The component only emits these flags without a direction. - Output schemas require properties that are always initialized (default value, promoted or constructor-set). Otherwise, mandatory constructor arguments are required. API Platform uses
ApiProperty::isRequired()(validation metadata or explicitrequired), with norequiredfor partial updates. callableandresourceproperties are removed. API Platform describes them astype: string.- Examples are
examples: [value]on JSON Schema 2020-12 and OpenAPI 3.1, andexampleonly on OpenAPI 3.0 (Dialect::example()). API Platform emitsexample. - Descriptions come from the PHPDoc. Values API Platform takes from metadata (
ApiPropertydescription,deprecated,externalDocsfromtypes, operation description) are not produced. - Ramsey
UuidInterfaceis not handled. API Platform describes it asformat: uuid.
3. Extension points
- The extension signatures have no operation or
ApiProperty. API Platform data has to go throughConfiguration::$context, which is neither part of the definition fingerprint nor of the default name. Any shape that depends on it (operation, partial update,gen_id) must be encoded in the name by a custom policy, or two shapes share one definition. SchemaDocument::reserve()anddefine()are@internal, and aDefinitionProcessorInterfacecan only change the definition it receives. Shared definitions such asHydraItemBaseSchemacannot be registered from an extension.- The root collection schema is not passed to any extension, so
hydra:member, JSON:APIdata/links/metaand HAL_embeddedstay in an outer decorator. - A
PropertySchemaProviderInterfacecan return user-defined schemas (ApiPropertyschema,jsonSchemaContext,openapiContext), but enrichers still run on top. API Platform leaves user-defined schemas untouched. - A definition is built for the first occurrence of a name, so shapes depending on the parent property (e.g.
gen_idon an embedded relation) collide: "a difference coming only from the parent cannot be detected and the first occurrence wins" (DefinitionPolicyInterface). - A
SchemaDocumentthrows when used with anotherrefPath, so JSON Schema (#/$defs/) and OpenAPI (#/components/schemas/) output cannot share one document.
Fits the existing extension points
- IRI references for non-embedded relations:
ClassSchemaResolverInterfacewithDefinitionParent. - Definition names:
DefinitionPolicyInterface. - Input/output DTOs: caller side.
- Validator constraints: built-in
ValidatorPropertySchemaEnricher. - Definitions shared across OpenAPI operations:
SchemaDocument,Dialect::openApi30()/openApi31(). - Eloquent models: the generator takes a
PropertyInfoExtractorInterface.
- Lenguaje dominante
- PHP
- Estrellas
- 2.6k
- Forks
- 989
- Merge medio
- 1 d 23 h
- PR fusionados (30 d)
- 102
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de api-platform/core
-
JSON:API: resource schemas (`*.jsonapi`) have `properties` but no `type: object`Posiblemente ocupada @ousamabenyounes la tomó hace 2 días. Abierto
Dificultad 2/5 Menos de una hora Aptitud para principiantes 80/100
api-platform/core#8701 ·
Los mantenedores suelen responder en 1 día
-
JSON:API: `JsonApiCollectionBaseSchemaNoPagination` declares `data` as `type: array` without `items`Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
api-platform/core#8699 ·
Los mantenedores suelen responder en 1 día
-
api:openapi:export --spec-version=3.0.0 outputs `webhooks`, which is invalid in OpenAPI 3.0Posiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
api-platform/core#8690 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
api-platform/core#8680 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
api-platform/core#8725 ·
Los mantenedores suelen responder en 1 día
Todos los issues de api-platform/core
Issues similares
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
nextcloud/integration_openai#446 ·
-
bug customer-reported
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
MagnaCapax/PMSS#1101 ·
Los mantenedores suelen responder en 5 días
-
InvoiceSettled is answered 200 when the invoice cannot be re-fetched, so BTCPay never redelivers itAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
btcpayserver/woocommerce-greenfield-plugin#93 ·
Los mantenedores suelen responder en 1 día
-
kind/bug status/triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
bug medium priority unconfirmed
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
filamentphp/filament#20760 · 1 comentario ·
Los mantenedores suelen responder en 1 día