[RCA] Collect bounded FODC metric windows
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- go
- Domain
- observability
Research direction
Start by resolving the blocked prerequisite #14223, then inspect the FODC API handlers in fodc/proxy/internal/api/server.go for /metrics-windows and /metrics, along with the existing metric-window tests. The CLI entry point and final test paths depend on seams introduced by that prerequisite. Done means a usable bounded collection operation, honest coverage and source status, and the specified fixture, timeout, malformed-response, oversized-response, cancellation, and conflict tests pass.
Written by the indexing model from the issue text.
Description
Umbrella: #14222
Blocked by: #14223
Summary
Collect bounded FODC metric windows. Deliver one usable operation, not a framework-only foundation.
Boundary
Proposed activation caller: bydbctl rca collect --source=fodc-metrics. Command names are proposed, not existing APIs.
Reporter collection runs with read-only source access; offline steps use local files only.
No source storage/wire-format changes are requested. The incident format is separately versioned.
Requirements
R1. Collect the requested incident window through the existing FODC API with explicit endpoint, node filters, deadline and byte cap.
R2. Preserve metric names, labels, timestamps and source identity; record requested versus observed time ranges and missing agents where the API provides them.
R3. Distinguish partial, unavailable, empty and complete evidence. Do not claim the recorder retained data outside its reported window; if coverage cannot be proved, record unknown.
R4. Write into the same private manifest without overwriting the native-log source status. Propagate cancellation and cap retries.
Acceptance criteria
- A recorded API fixture has two agents, one expired interval and one unavailable agent. Independently specified samples survive unchanged and coverage names both gaps.
- Exercise the CLI against a FODC fixture server including timeout, malformed response and an oversized response. All terminate within configured test bounds and leave an honest source status.
- Use hand-authored or independently captured fixtures with documented provenance; do not generate expected values using the code under test.
- Add focused behavioral tests before implementation and record the actual RED command/failure, then GREEN results.
- Keep existing CLI/API behavior compatible. Never overwrite unrelated user files; output conflicts must be refused.
Scope and readiness audit
- Boundary and behavior: the single operation above; independently observable output and refusal behavior.
- Production activation: the named CLI or skill entry point above, included in the same PR.
- Packages/callers: fodc/proxy/internal/api/server.go /metrics-windows and /metrics; existing FODC metric-window tests.
- Dependencies: #14223
- Classification: planned blocked leaf; revalidate prerequisite seams after merge.
- RED evidence: not executed during this planning task; no claim of passing or failing implementation tests.
- End-to-end proof: the real command/skill scenarios above, not source-text assertions.
- Formats/lifecycle/fixtures: private workspace or public archive only; artifact-specific fixture family above.
- Focused tests: CLI leaves should add
TestRCA…coverage underbydbctl/internal/cmdand/or the introduced collector package;
rungo test ./bydbctl/internal/cmd -run TestRCA -count=1plus the new package tests. Skill leaves must add a replayable evaluation harness
with an exact command documented in the PR. Final test names/paths are fixed when the prerequisite seam merges. - Resource/concurrency checks: cancellation, bounded reads/output and cleanup on failure; use repository panic-aware goroutine wrappers if concurrency is introduced.
- Decision: one proposed PR. If the named behavior requires an unimplemented server API or another lifecycle change, stop and split that prerequisite.
Required-only scope audit
Metrics are a requested diagnostic source; a new monitoring system is not.
Removed/deferred: New metric retention, new alert configuration, automatic discovery and new collection endpoints.
Out of scope
New metric retention, Prometheus deployment, alerts, changing FODC ring buffers.
- Dominant language
- Java
- Stars
- 25k
- Forks
- 6.6k
- Avg merge
- 12h 1m
- Merged PRs (30d)
- 43
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/skywalking
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/skywalking#14239 ·
Maintainers usually reply within 1 day
-
AI Assistant database enhancement
Difficulty 5/5 Over a week Newbie friendliness 24/100
apache/skywalking#14237 ·
Maintainers usually reply within 1 day
-
database enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/skywalking#14236 ·
Maintainers usually reply within 1 day
-
AI Assistant database enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/skywalking#14235 ·
Maintainers usually reply within 1 day
-
database enhancement
Difficulty 5/5 Over a week Newbie friendliness 30/100
apache/skywalking#14234 ·
Maintainers usually reply within 1 day
All issues in apache/skywalking
Similar issues
-
Re-executed query with IN condition on an index column returns deleted rows (stale IndexCursor)Possibly taken @dbusche claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
h2database/h2database#4580 ·
Maintainers usually reply within 1 day
-
vips-drift
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Stirling-Tools/JPDFium#300 ·
Maintainers usually reply within 1 day
-
hermes-queue
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
chrisalunlloyd2-sudo/mindpalace#403 ·
Maintainers usually reply within 1 day
-
Guidelines: document how to build a use case against a local, unpublished Flow/browserless-test changePossibly taken @totally-not-ai claimed this today. Open
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
vaadin/use-cases#452 · 1 comment ·
Maintainers usually reply within 1 day
-
area/storage area/storage/sql
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Apicurio/apicurio-registry#11159 ·
Maintainers usually reply within 1 day