[Bug] JDBC trace profiling query fails with SQL syntax error when the segment list is empty
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- backend-api-design, databases
Research direction
Start with JDBCTraceQueryDAO.queryBySegmentIdList in the stack trace and trace how ProfileTaskQueryService.getTaskSegments passes the segment IDs. Check the JDBC DAO tests for a place to add an empty collection regression case. Done means a task with no sampled segments returns an empty list without producing invalid SQL.
Written by the indexing model from the issue text.
Description
Search before asking
- I had searched in the issues and found no similar issues.
Apache SkyWalking Component
OAP server (apache/skywalking)
What happened
Opening trace profiling results for a task with no collected calls fails with a MariaDB SQL syntax error at GraphQL /segmentList. Locally, the failure occurs when there are no collected calls.
Environment
- OAP image: apache/skywalking-oap-server:11.1.0
- Horizon image: ghcr.io/apache/skywalking-horizon-ui:1.1.0
- Storage: MariaDB, SW_STORAGE=mysql
- MySQL Connector/J: 8.4.0
What you expected to happen
A profiling task with no sampled segments should return an empty list, allowing the UI to display no data, without executing invalid SQL.
How to reproduce
- Run OAP with JDBC/MySQL storage backed by MariaDB.
- Create a trace profiling task for an instrumented service.
- Do not generate matching calls / collected profiling segments.
- Open the task segment list in Horizon Trace Profiling (GraphQL getProfileTaskSegments).
- Observe the SQLSyntaxErrorException at /segmentList.
Anything else
Observed OAP stack trace
Exception while fetching data (/segmentList): java.sql.SQLSyntaxErrorException:
You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version
for the right syntax to use near ')' at line 1
at org.apache.skywalking.oap.server.library.client.jdbc.hikaricp.JDBCClient.executeQuery(JDBCClient.java:118)
at org.apache.skywalking.oap.server.storage.plugin.jdbc.common.dao.JDBCTraceQueryDAO.queryBySegmentIdList(JDBCTraceQueryDAO.java:265)
at org.apache.skywalking.oap.server.core.profiling.trace.ProfileTaskQueryService.getTaskSegments(ProfileTaskQueryService.java:202)
at org.apache.skywalking.oap.server.core.profiling.trace.ProfileTaskQueryService.getProfileTaskSegments(ProfileTaskQueryService.java:207)
at org.apache.skywalking.oap.query.graphql.resolver.ProfileQuery.lambda$getProfileTaskSegments$2(ProfileQuery.java:66)
Suspected cause: an empty segment ID collection reaches queryBySegmentIdList and produces an empty IN () predicate. The full generated SQL was not captured, so this SQL shape is an inference from the trigger and stack trace. Please check empty-list handling and add an empty-collection regression test.
Searched existing issues for segmentList + syntax and queryBySegmentIdList + empty. #14172 concerns profiling records disappearing with BanyanDB; this report concerns a JDBC/MariaDB syntax error. No local OAP code modification has been applied.
Are you willing to submit a pull request to fix on your own?
- Yes I am willing to submit a pull request on my own!
Code of Conduct
- I agree to follow this project's Code of Conduct
- Dominant language
- Java
- Stars
- 25k
- Forks
- 6.6k
- Avg merge
- 12h 1m
- Merged PRs (30d)
- 43
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/skywalking
-
AI Assistant database enhancement
Difficulty 5/5 Over a week Newbie friendliness 24/100
apache/skywalking#14237 ·
Maintainers usually reply within 1 day
-
database enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/skywalking#14236 ·
Maintainers usually reply within 1 day
-
AI Assistant database enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/skywalking#14235 ·
Maintainers usually reply within 1 day
-
database enhancement
Difficulty 5/5 Over a week Newbie friendliness 30/100
apache/skywalking#14234 ·
Maintainers usually reply within 1 day
-
database enhancement query tracing
Difficulty 5/5 Over a week Newbie friendliness 35/100
apache/skywalking#14233 ·
Maintainers usually reply within 1 day
All issues in apache/skywalking
Similar issues
-
Re-executed query with IN condition on an index column returns deleted rows (stale IndexCursor)Possibly taken @dbusche claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
h2database/h2database#4580 ·
Maintainers usually reply within 1 day
-
vips-drift
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Stirling-Tools/JPDFium#300 ·
Maintainers usually reply within 1 day
-
hermes-queue
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
chrisalunlloyd2-sudo/mindpalace#403 ·
Maintainers usually reply within 1 day
-
Guidelines: document how to build a use case against a local, unpublished Flow/browserless-test changePossibly taken @totally-not-ai claimed this today. Open
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
vaadin/use-cases#452 · 1 comment ·
Maintainers usually reply within 1 day
-
area/storage area/storage/sql
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Apicurio/apicurio-registry#11159 ·
Maintainers usually reply within 1 day