[RCA] Collect bounded FODC metric windows

Đang mở
#14,225 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
25/100
Loại issue
Tính năng
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
go
Lĩnh vực
observability

Hướng nghiên cứu

Start by resolving the blocked prerequisite #14223, then inspect the FODC API handlers in fodc/proxy/internal/api/server.go for /metrics-windows and /metrics, along with the existing metric-window tests. The CLI entry point and final test paths depend on seams introduced by that prerequisite. Done means a usable bounded collection operation, honest coverage and source status, and the specified fixture, timeout, malformed-response, oversized-response, cancellation, and conflict tests pass.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

database enhancement metrics

Umbrella: #14222

Blocked by: #14223

Summary

Collect bounded FODC metric windows. Deliver one usable operation, not a framework-only foundation.

Boundary

Proposed activation caller: bydbctl rca collect --source=fodc-metrics. Command names are proposed, not existing APIs.
Reporter collection runs with read-only source access; offline steps use local files only.
No source storage/wire-format changes are requested. The incident format is separately versioned.

Requirements

R1. Collect the requested incident window through the existing FODC API with explicit endpoint, node filters, deadline and byte cap.
R2. Preserve metric names, labels, timestamps and source identity; record requested versus observed time ranges and missing agents where the API provides them.
R3. Distinguish partial, unavailable, empty and complete evidence. Do not claim the recorder retained data outside its reported window; if coverage cannot be proved, record unknown.
R4. Write into the same private manifest without overwriting the native-log source status. Propagate cancellation and cap retries.

Acceptance criteria

  • A recorded API fixture has two agents, one expired interval and one unavailable agent. Independently specified samples survive unchanged and coverage names both gaps.
  • Exercise the CLI against a FODC fixture server including timeout, malformed response and an oversized response. All terminate within configured test bounds and leave an honest source status.
  • Use hand-authored or independently captured fixtures with documented provenance; do not generate expected values using the code under test.
  • Add focused behavioral tests before implementation and record the actual RED command/failure, then GREEN results.
  • Keep existing CLI/API behavior compatible. Never overwrite unrelated user files; output conflicts must be refused.

Scope and readiness audit

  • Boundary and behavior: the single operation above; independently observable output and refusal behavior.
  • Production activation: the named CLI or skill entry point above, included in the same PR.
  • Packages/callers: fodc/proxy/internal/api/server.go /metrics-windows and /metrics; existing FODC metric-window tests.
  • Dependencies: #14223
  • Classification: planned blocked leaf; revalidate prerequisite seams after merge.
  • RED evidence: not executed during this planning task; no claim of passing or failing implementation tests.
  • End-to-end proof: the real command/skill scenarios above, not source-text assertions.
  • Formats/lifecycle/fixtures: private workspace or public archive only; artifact-specific fixture family above.
  • Focused tests: CLI leaves should add TestRCA… coverage under bydbctl/internal/cmd and/or the introduced collector package;
    run go test ./bydbctl/internal/cmd -run TestRCA -count=1 plus the new package tests. Skill leaves must add a replayable evaluation harness
    with an exact command documented in the PR. Final test names/paths are fixed when the prerequisite seam merges.
  • Resource/concurrency checks: cancellation, bounded reads/output and cleanup on failure; use repository panic-aware goroutine wrappers if concurrency is introduced.
  • Decision: one proposed PR. If the named behavior requires an unimplemented server API or another lifecycle change, stop and split that prerequisite.

Required-only scope audit

Metrics are a requested diagnostic source; a new monitoring system is not.

Removed/deferred: New metric retention, new alert configuration, automatic discovery and new collection endpoints.

Out of scope

New metric retention, Prometheus deployment, alerts, changing FODC ring buffers.

Ngôn ngữ chính
Java
Star
25k
Fork
6.6k
Merge trung bình
12 giờ 1 phút
Pull request đã merge (30 ngày)
43

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của apache/skywalking

Tất cả issue của apache/skywalking

Issue tương tự

Thêm issue về Java

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.