[Feature] Expose call metrics for the proxy admin gRPC interface

Open
  • Is something wrong?
#11,474 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@Felix-Gong is already working on this.

Since Oct 21, 2026.

  • #11475 by @Felix-Gong — open

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
54/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
grpc, java
Domain
backend-api-design, observability

Research direction

Start in the proxy module with ProxyAdminAuthInterceptor and ProxyMetricsManager, then read how the broker handles optional instruments and inspect the proxy tests. Add per-RPC counts and latency samples labeled by method and terminal status, including calls rejected by the interceptor; verify they export through the existing pipeline and become no-ops when metrics are unavailable.

Written by the indexing model from the issue text.

Description

Search before asking

I checked open and closed issues and PRs for proxy admin metrics, OpenTelemetry on the control plane and admin gRPC instrumentation. What exists is adjacent, not this:

  • #10901 / #10833 touch how metric config values are parsed (OTLP headers, colon-separated labels); #10950 masks them in config logs.
  • #10603 (RIP-2) adds its own ClientAdminMetricsRecorder for the new client-admin query endpoint — service-level instrumentation for code that does not exist on develop yet.
  • #10825 tracks the admin interface work in general.

Nothing records anything for the admin gRPC server that actually ships today: ProxyAdminAuthInterceptor answers every admin RPC (thread dumps, message verification, group resets, topic updates...) and rocketmq_proxy_up is the only proxy instrument in the pipeline.

What happened?

ProxyMetricsManager initializes an OpenTelemetry meter in both proxy modes and exports it (OTLP/Prometheus/log), but the only instrument it registers is the rocketmq_proxy_up gauge. The admin gRPC server — the control plane surface every ops tool talks to — contributes no counter, no latency histogram, no error count.

So on a running proxy you cannot answer: is the admin interface being called at all, which methods are hot, how long do admin calls take, and — the important one — is anything failing (auth rejections, broken forwards, internal errors) while the dashboard still shows a healthy rocketmq_proxy_up = 1.

Expected behavior

Each admin RPC should produce one count and one latency sample, labeled with the method name and terminal status code, exported through the proxy's existing OpenTelemetry pipeline alongside rocketmq_proxy_up. Calls rejected by the auth interceptor should be counted too (that is where failures would show up first), and everything should degrade to a no-op when metrics are disabled or the manager has not started — same idiom the broker uses for optional instruments.

Runtime

develop at 57c2dc0, JDK 11. No proto change, no new dependency: the interceptor, the two instruments and tests live entirely in proxy.

Dominant language
Java
Stars
22.7k
Forks
12k
Avg merge
3d 18h
Merged PRs (30d)
17

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/rocketmq

All issues in apache/rocketmq

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.