[Feature] Expose call metrics for the proxy admin gRPC interface

Aperta
  • Qualcosa non va?
#11,474 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Felix-Gong ci sta già lavorando.

Dal 21/10/2026.

  • #11475 di @Felix-Gong — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
54/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
grpc, java
Ambito
backend-api-design, observability

Direzione di ricerca

Start in the proxy module with ProxyAdminAuthInterceptor and ProxyMetricsManager, then read how the broker handles optional instruments and inspect the proxy tests. Add per-RPC counts and latency samples labeled by method and terminal status, including calls rejected by the interceptor; verify they export through the existing pipeline and become no-ops when metrics are unavailable.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Search before asking

I checked open and closed issues and PRs for proxy admin metrics, OpenTelemetry on the control plane and admin gRPC instrumentation. What exists is adjacent, not this:

  • #10901 / #10833 touch how metric config values are parsed (OTLP headers, colon-separated labels); #10950 masks them in config logs.
  • #10603 (RIP-2) adds its own ClientAdminMetricsRecorder for the new client-admin query endpoint — service-level instrumentation for code that does not exist on develop yet.
  • #10825 tracks the admin interface work in general.

Nothing records anything for the admin gRPC server that actually ships today: ProxyAdminAuthInterceptor answers every admin RPC (thread dumps, message verification, group resets, topic updates...) and rocketmq_proxy_up is the only proxy instrument in the pipeline.

What happened?

ProxyMetricsManager initializes an OpenTelemetry meter in both proxy modes and exports it (OTLP/Prometheus/log), but the only instrument it registers is the rocketmq_proxy_up gauge. The admin gRPC server — the control plane surface every ops tool talks to — contributes no counter, no latency histogram, no error count.

So on a running proxy you cannot answer: is the admin interface being called at all, which methods are hot, how long do admin calls take, and — the important one — is anything failing (auth rejections, broken forwards, internal errors) while the dashboard still shows a healthy rocketmq_proxy_up = 1.

Expected behavior

Each admin RPC should produce one count and one latency sample, labeled with the method name and terminal status code, exported through the proxy's existing OpenTelemetry pipeline alongside rocketmq_proxy_up. Calls rejected by the auth interceptor should be counted too (that is where failures would show up first), and everything should degrade to a no-op when metrics are disabled or the manager has not started — same idiom the broker uses for optional instruments.

Runtime

develop at 57c2dc0, JDK 11. No proto change, no new dependency: the interceptor, the two instruments and tests live entirely in proxy.

Lingua principale
Java
Stelle
22.7k
Fork
12k
Merge medio
3g 18h
PR unite (30g)
17

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/rocketmq

Tutte le issue di apache/rocketmq

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.