[Feature] Expose call metrics for the proxy admin gRPC interface

Abierto
  • ¿Algo no está bien?
#11,474 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@Felix-Gong ya está trabajando en esto.

Desde el 21/10/2026.

  • #11475 de @Felix-Gong — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
54/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
grpc, java
Área
backend-api-design, observability

Línea de trabajo

Start in the proxy module with ProxyAdminAuthInterceptor and ProxyMetricsManager, then read how the broker handles optional instruments and inspect the proxy tests. Add per-RPC counts and latency samples labeled by method and terminal status, including calls rejected by the interceptor; verify they export through the existing pipeline and become no-ops when metrics are unavailable.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Search before asking

I checked open and closed issues and PRs for proxy admin metrics, OpenTelemetry on the control plane and admin gRPC instrumentation. What exists is adjacent, not this:

  • #10901 / #10833 touch how metric config values are parsed (OTLP headers, colon-separated labels); #10950 masks them in config logs.
  • #10603 (RIP-2) adds its own ClientAdminMetricsRecorder for the new client-admin query endpoint — service-level instrumentation for code that does not exist on develop yet.
  • #10825 tracks the admin interface work in general.

Nothing records anything for the admin gRPC server that actually ships today: ProxyAdminAuthInterceptor answers every admin RPC (thread dumps, message verification, group resets, topic updates...) and rocketmq_proxy_up is the only proxy instrument in the pipeline.

What happened?

ProxyMetricsManager initializes an OpenTelemetry meter in both proxy modes and exports it (OTLP/Prometheus/log), but the only instrument it registers is the rocketmq_proxy_up gauge. The admin gRPC server — the control plane surface every ops tool talks to — contributes no counter, no latency histogram, no error count.

So on a running proxy you cannot answer: is the admin interface being called at all, which methods are hot, how long do admin calls take, and — the important one — is anything failing (auth rejections, broken forwards, internal errors) while the dashboard still shows a healthy rocketmq_proxy_up = 1.

Expected behavior

Each admin RPC should produce one count and one latency sample, labeled with the method name and terminal status code, exported through the proxy's existing OpenTelemetry pipeline alongside rocketmq_proxy_up. Calls rejected by the auth interceptor should be counted too (that is where failures would show up first), and everything should degrade to a no-op when metrics are disabled or the manager has not started — same idiom the broker uses for optional instruments.

Runtime

develop at 57c2dc0, JDK 11. No proto change, no new dependency: the interceptor, the two instruments and tests live entirely in proxy.

Lenguaje dominante
Java
Estrellas
22.7k
Forks
12k
Merge medio
3 d 18 h
PR fusionados (30 d)
17

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/rocketmq

Todos los issues de apache/rocketmq

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.