[Task] Correct source attribution and align copyright years following LEGAL-737

Open
  • Is something wrong?
#1,322 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@himanchalkaushale is already working on this.

Since Nov 10, 2026.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
java
Domain
devtools, documentation

Research direction

Start by checking the provenance of the 12 named classes in fesod-common and fesod-sheet, then inspect other EasyExcel files that already carry ASF headers. Use upstream references to decide which attributions apply and reconcile source header years with NOTICE. Done means the attribution and year ranges are consistent, license headers are preserved, and provenance evidence and remediation links are recorded; the issue also asks for a report to LEGAL-737.

Written by the indexing model from the issue text.

Description

good first issue
Motivation

This issue tracks the implementation follow-up to #1106 based on Justin Mclean's review in LEGAL-737.

Justin agreed that retaining Alibaba attribution in EasyExcel-derived files is acceptable (option A / the Pekko approach), because the EasyExcel code is outside the SGA scope. The current layout—an ASF header followed by Alibaba attribution in a separate comment block—is acceptable, and LICENSE needs no changes.

However, his review identified incorrect attribution on ASF-origin files and inconsistent copyright years. He also clarified that the Alibaba lines were added by the Fesod project rather than inherited from upstream EasyExcel. Their placement therefore needs to be checked against actual code provenance.

How to complete
  1. Audit files carrying Alibaba attribution and distinguish:
    • EasyExcel-derived code, where Alibaba attribution may remain.
    • New FastExcel/Fesod code covered by the SGA, where Alibaba attribution should not appear.
    • Code originating from Apache POI or Apache Commons, where the incorrectly added Alibaba line should be removed and the ASF header retained.
  2. Start with the files Justin identified below, then check other EasyExcel files that already carried an ASF header. Record upstream references supporting the changes.
  3. Reconcile the source-header year range (2018–2024) with NOTICE (2022–2024). Choose a consistent range supported by the provenance review; the comment does not prescribe which range to use.
  4. Keep the accepted header layout for applicable EasyExcel-derived files. Restoring @author tags is not required by the review.

Files identified by Justin (not an exhaustive list):

Module Classes
fesod-common StringUtils, BooleanUtils, ListUtils, MapUtils, MemberUtils
fesod-sheet Validate, DateUtils, DataFormatter, FileUtils, ClassUtils, FieldUtils, SharedStringsTableHandler
Task List
  • Verify the provenance of the 12 identified classes and remove their incorrect Alibaba attribution.
  • Check for additional ASF-origin files with the same attribution problem.
  • Ensure Alibaba attribution is limited to applicable EasyExcel-derived code and absent from new SGA-covered FastExcel/Fesod code.
  • Make the relevant source-header and NOTICE year ranges consistent, documenting the basis for the selected range.
  • Verify the diff preserves ASF license headers and makes no functional changes; pass the repository's formatting and license-header checks.
  • Link the remediation PR(s) and provenance evidence here and in #1106.
  • Report the completed changes back to LEGAL-737 and request confirmation that the remaining concerns are addressed.
Anything else?
  • Related decision tracking: #1106
  • Legal discussion and review: LEGAL-737

This issue tracks the concrete attribution cleanup requested in the review. It does not assume that LEGAL-737 has been formally resolved or that graduation approval has been granted.

Dominant language
Java
Stars
6.3k
Forks
554
Avg merge
1d 21h
Merged PRs (30d)
44

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/fesod

All issues in apache/fesod

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.