Four TestConstraintBasedAlgorithm tests pass when nothing is thrown
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
Research direction
In helix-core, inspect the four named TestConstraintBasedAlgorithm tests and their exception assertions. Add a failure assertion after each calculate call, then run those tests to confirm they still pass because the expected exception is thrown.
Written by the indexing model from the issue text.
Description
testCalculateNoValidAssignment, testCalculateNoValidAssignmentFirstAndThenRecovery, testSortingEarlyQuitLackCapacity and testCalculateWithInvalidAssignmentForNodeCapacity in helix-core call algorithm.calculate(clusterModel) in a try and assert only inside catch (HelixRebalanceException ex). There is no Assert.fail() after the call, so they pass when calculate returns normally.
I have a branch that adds the Assert.fail(). All four still pass, so the exception is thrown today.
- Dominant language
- Java
- Stars
- 505
- Forks
- 258
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/helix
-
Helix ZkClient times out after successful ZooKeeper SASL DIGEST-MD5 authenticationPossibly taken @adityaanikam claimed this 43 days ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
NPE in canCompleteSwap if path doesn't existsPossibly taken @waterWang claimed this 106 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
-
Legacy IZkStateListenerI0ItecImpl causes zombie participants by discarding session IDsPossibly taken @LZD-PratyushBhatt claimed this 457 days ago. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
bug documentation good first issue help wanted priority low size XS
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
martin-francois/symphony-trello#1351 ·
Maintainers usually reply within 1 day
-
Add test coverage for ConvertUtil.parseDate() with NULL inputPossibly taken @mirajul-mollah7 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 78/100
eclipse-sw360/sw360#4792 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
aws/aws-emulator#30 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 4 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100