[Task] Correct source attribution and align copyright years following LEGAL-737

未关闭
  • 哪里不对？
#1,322 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@himanchalkaushale 已经在做这个了。

开始于 2026年11月10日。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
java
领域
devtools, documentation

调研方向

Start by checking the provenance of the 12 named classes in fesod-common and fesod-sheet, then inspect other EasyExcel files that already carry ASF headers. Use upstream references to decide which attributions apply and reconcile source header years with NOTICE. Done means the attribution and year ranges are consistent, license headers are preserved, and provenance evidence and remediation links are recorded; the issue also asks for a report to LEGAL-737.

由索引模型根据 Issue 内容生成。

描述

good first issue
Motivation

This issue tracks the implementation follow-up to #1106 based on Justin Mclean's review in LEGAL-737.

Justin agreed that retaining Alibaba attribution in EasyExcel-derived files is acceptable (option A / the Pekko approach), because the EasyExcel code is outside the SGA scope. The current layout—an ASF header followed by Alibaba attribution in a separate comment block—is acceptable, and LICENSE needs no changes.

However, his review identified incorrect attribution on ASF-origin files and inconsistent copyright years. He also clarified that the Alibaba lines were added by the Fesod project rather than inherited from upstream EasyExcel. Their placement therefore needs to be checked against actual code provenance.

How to complete
  1. Audit files carrying Alibaba attribution and distinguish:
    • EasyExcel-derived code, where Alibaba attribution may remain.
    • New FastExcel/Fesod code covered by the SGA, where Alibaba attribution should not appear.
    • Code originating from Apache POI or Apache Commons, where the incorrectly added Alibaba line should be removed and the ASF header retained.
  2. Start with the files Justin identified below, then check other EasyExcel files that already carried an ASF header. Record upstream references supporting the changes.
  3. Reconcile the source-header year range (2018–2024) with NOTICE (2022–2024). Choose a consistent range supported by the provenance review; the comment does not prescribe which range to use.
  4. Keep the accepted header layout for applicable EasyExcel-derived files. Restoring @author tags is not required by the review.

Files identified by Justin (not an exhaustive list):

Module Classes
fesod-common StringUtils, BooleanUtils, ListUtils, MapUtils, MemberUtils
fesod-sheet Validate, DateUtils, DataFormatter, FileUtils, ClassUtils, FieldUtils, SharedStringsTableHandler
Task List
  • Verify the provenance of the 12 identified classes and remove their incorrect Alibaba attribution.
  • Check for additional ASF-origin files with the same attribution problem.
  • Ensure Alibaba attribution is limited to applicable EasyExcel-derived code and absent from new SGA-covered FastExcel/Fesod code.
  • Make the relevant source-header and NOTICE year ranges consistent, documenting the basis for the selected range.
  • Verify the diff preserves ASF license headers and makes no functional changes; pass the repository's formatting and license-header checks.
  • Link the remediation PR(s) and provenance evidence here and in #1106.
  • Report the completed changes back to LEGAL-737 and request confirmation that the remaining concerns are addressed.
Anything else?
  • Related decision tracking: #1106
  • Legal discussion and review: LEGAL-737

This issue tracks the concrete attribution cleanup requested in the review. It does not assume that LEGAL-737 has been formally resolved or that graduation approval has been granted.

主要语言
Java
星标
6.3k
派生
554
平均合并
1 天 21 小时
30 天内合并 PR
44

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

apache/fesod 的其他 Issue

查看 apache/fesod 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。