Offline collection volume loses deletion retry information

Open
#23,381 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
android, kotlin
Domain
backend, mobile

Research direction

Start with ProfileManager.deleteProfile and the collection path helpers it uses, then inspect ProfileManagerTest.kt, especially the offline volume regression test described in this issue. Check how deletion failures affect profile settings and whether a retry can complete cleanup after the volume is mounted again. Done when the profile and its collection data are both removed after a failed offline deletion is retried.

Written by the indexing model from the issue text.

Description

Multi Profile

Assisted-by: GPT-6.1-Sol xhigh & GPT-6-Astra xhigh

[EXISTING] Offline collection volume loses deletion retry information
Subject: [EXISTING] Offline collection volume loses deletion retry information

Deleting a profile while its collection volume is unmounted removes the profile settings and leaves its cards, media, and backups behind.

⚠️ This issue existed before the PR and should likely be split off into a separate issue.
The new delete action exposes the pre-existing helper defect.

---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/multiprofile/ProfileManagerTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/multiprofile/ProfileManagerTest.kt
index 6492405d73..e44a464313 100644
--- a/AnkiDroid/src/test/java/com/ichi2/anki/multiprofile/ProfileManagerTest.kt
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/multiprofile/ProfileManagerTest.kt
@@ -1187,6 +1187,44 @@ class ProfileManagerTest {
         }
     }
 
+    @Test
+    fun `an offline collection volume keeps settings until it can be deleted`() {
+        val manager = ProfileManager.create(context)
+        val work = manager.createNewProfile(ProfileName.fromTrustedSource("Work"))
+        val mount = File(appDataRoot, "removable_card").apply { mkdirs() }
+        val detached = File(appDataRoot, "detached_card")
+        val collectionDir = File(mount, "AnkiDroid").apply { mkdirs() }
+        val collection = File(collectionDir, "collection.anki2").apply { writeText("collection") }
+        val media = File(collectionDir, "collection.media/image.jpg").apply {
+            parentFile!!.mkdirs()
+            writeText("media")
+        }
+        writeProfileCollectionPath(work, collectionDir)
+        val settings = File(appDataRoot, "shared_prefs/profile_${work.value}_${context.packageName}_preferences.xml")
+        ShadowEnvironment.setExternalStorageRemovable(mount, true)
+        ShadowEnvironment.setExternalStorageState(mount, Environment.MEDIA_MOUNTED)
+        assertTrue(mount.renameTo(detached))
+        ShadowEnvironment.setExternalStorageState(mount, Environment.MEDIA_UNMOUNTED)
+        try {
+            assertEquals(Environment.MEDIA_UNMOUNTED, Environment.getExternalStorageState(collectionDir))
+            assertFalse(collectionDir.exists())
+
+            assertThrows(IOException::class.java) { manager.deleteProfile(work) }
+
+            assertTrue(manager.getAllProfiles().containsKey(work))
+            assertTrue(settings.exists())
+        } finally {
+            assertTrue(detached.renameTo(mount))
+            ShadowEnvironment.setExternalStorageState(mount, Environment.MEDIA_MOUNTED)
+        }
+
+        manager.deleteProfile(work)
+
+        assertFalse(collection.exists())
+        assertFalse(media.exists())
+        assertFalse(manager.getAllProfiles().containsKey(work))
+    }
+
     /** Stubs [CookieManager.getInstance]. [completesRemoval] fires the cookie removal callback. */
     private class RecordingEditor(
         private val delegate: SharedPreferences.Editor,

Originally posted by @david-allison in https://github.com/ankidroid/Anki-Android/pull/23329#pullrequestreview-5926332571

Dominant language
Kotlin
Stars
12.3k
Forks
3.1k
Avg merge
1d 11h
Merged PRs (30d)
383

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ankidroid/Anki-Android

All issues in ankidroid/Anki-Android

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.