Unreadable collection loses deletion retry information
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 62/100
Research direction
Start with ProfileManagerTest.kt, especially the profile deletion tests and the unreadable collection case shown in the issue. Trace the deletion helper that lists the collection directory and check how it handles listing failures. Done means deletion preserves the profile and its settings when the collection cannot be read, with a regression test covering the retry case.
Written by the indexing model from the issue text.
Description
Assisted-by: GPT-6.1-Sol xhigh & GPT-6-Astra xhigh
[EXISTING] Unreadable collection loses deletion retry information
Subject: [EXISTING] Unreadable collection loses deletion retry information
When a collection directory cannot be listed, deletion removes its profile and settings while leaving its data behind.
⚠️ This issue existed before the PR and should likely be split off into a separate issue.
The new delete action exposes the pre-existing helper defect.
---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/multiprofile/ProfileManagerTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/multiprofile/ProfileManagerTest.kt
index 3297d2a617..8aa9575f84 100644
--- a/AnkiDroid/src/test/java/com/ichi2/anki/multiprofile/ProfileManagerTest.kt
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/multiprofile/ProfileManagerTest.kt
@@ -1124,6 +1124,27 @@ class ProfileManagerTest {
assertTrue("Unrecognized collection exports must survive profile deletion", otherCollection.exists())
}
+ @Test
+ fun `an unreadable collection keeps the profile and its settings for retry`() {
+ val manager = ProfileManager.create(context)
+ val work = manager.createNewProfile(ProfileName.fromTrustedSource("Work"))
+ val collectionDir = File(context.getExternalFilesDir(null), "unreadable_collection").apply { mkdirs() }
+ File(collectionDir, "collection.anki2").writeText("collection")
+ writeProfileCollectionPath(work, collectionDir)
+ val settings = File(appDataRoot, "shared_prefs/profile_${work.value}_${context.packageName}_preferences.xml")
+ org.junit.Assume.assumeTrue(collectionDir.setReadable(false, false))
+ try {
+ org.junit.Assume.assumeFalse("The test runner must respect directory permissions", collectionDir.canRead())
+
+ assertThrows(IOException::class.java) { manager.deleteProfile(work) }
+
+ assertTrue(manager.getAllProfiles().containsKey(work))
+ assertTrue(settings.exists())
+ } finally {
+ collectionDir.setReadable(true, true)
+ }
+ }
+
/** Stubs [CookieManager.getInstance]. [completesRemoval] fires the cookie removal callback. */
private class RecordingEditor(
private val delegate: SharedPreferences.Editor,
Originally posted by @david-allison in https://github.com/ankidroid/Anki-Android/pull/23329#pullrequestreview-5926332571
- Dominant language
- Kotlin
- Stars
- 12.3k
- Forks
- 3.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 383
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ankidroid/Anki-Android
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23392 ·
Maintainers usually reply within 1 day
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23390 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23385 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23374 ·
Maintainers usually reply within 1 day
-
Selected custom-study tags become unreadablePossibly taken @chesh-ire claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ankidroid/Anki-Android#23352 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in ankidroid/Anki-Android
Similar issues
-
Bug Domain changed
Difficulty 1/5 Under an hour Newbie friendliness 79/100
keiyoushi/extensions-source#21174 ·
Maintainers usually reply within 1 day
-
Unified account interface not translated into Simplified ChinesePossibly taken @xuenhua claimed this 3 days ago. Openunconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
thunderbird/thunderbird-android#11936 · 1 comment ·
Maintainers usually reply within 3 days
-
Update toast stylingOpendesign good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
scribe-org/Scribe-Android#778 ·
Maintainers usually reply within 1 day
-
AI Generated CI/CD ⚒️ Flaky-tests 🐦 go 🏃
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
valkey-io/valkey-glide#7772 ·
Maintainers usually reply within 1 day
-
Error Handling Swift
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Automattic/wordpress-rs#1759 ·
Maintainers usually reply within 1 day