Voice typing a tag with spaces duplicates the text
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 54/100
Research direction
Start with TagNameInputFilterTest.kt, which reproduces the duplicate text by sending successive composing updates through an EditText input connection. Find where the tag dialog fields install tagNameInputFilter and trace how it handles composing text that contains spaces. Confirm the fix by checking that the test's final text is cell::biology::is.
Written by the indexing model from the issue text.
Description
Assisted-by: Opus 5.5 max
Subject: [EXISTING] Voice typing a tag with spaces duplicates the text
When an IME updates composing text containing a space, as voice typing does in the tag dialog fields, the converted text is inserted twice.
⚠️ This issue existed before the PR and should likely be split off into a separate issue. This PR extends the trigger to ideographic spaces.
---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/tags/TagNameInputFilterTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/tags/TagNameInputFilterTest.kt
new file mode 100644
index 0000000000..de09d488b3
--- /dev/null
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/tags/TagNameInputFilterTest.kt
@@ -0,0 +1,27 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+package com.ichi2.anki.tags
+
+import android.view.inputmethod.EditorInfo
+import android.widget.EditText
+import androidx.test.core.app.ApplicationProvider
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import org.junit.Test
+import org.junit.runner.RunWith
+import kotlin.test.assertEquals
+
+@RunWith(AndroidJUnit4::class)
+class TagNameInputFilterTest {
+ @Test
+ fun `updating composing text that contains a space replaces the composition`() {
+ val editText = EditText(ApplicationProvider.getApplicationContext())
+ editText.filters = arrayOf(tagNameInputFilter)
+ val inputConnection = editText.onCreateInputConnection(EditorInfo())
+
+ // Voice typing streams a growing phrase as composing text
+ inputConnection.setComposingText("cell biology", 1)
+ inputConnection.setComposingText("cell biology is", 1)
+
+ assertEquals("cell::biology::is", editText.text.toString())
+ }
+}
Originally posted by @criticalAY in https://github.com/ankidroid/Anki-Android/pull/22849#pullrequestreview-5940650367
- Dominant language
- Kotlin
- Stars
- 12.3k
- Forks
- 3.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 383
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ankidroid/Anki-Android
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23392 ·
Maintainers usually reply within 1 day
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23390 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23385 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23374 ·
Maintainers usually reply within 1 day
-
Selected custom-study tags become unreadablePossibly taken @chesh-ire claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ankidroid/Anki-Android#23352 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in ankidroid/Anki-Android
Similar issues
-
Bug Domain changed
Difficulty 1/5 Under an hour Newbie friendliness 79/100
keiyoushi/extensions-source#21174 ·
Maintainers usually reply within 1 day
-
Unified account interface not translated into Simplified ChinesePossibly taken @xuenhua claimed this 3 days ago. Openunconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
thunderbird/thunderbird-android#11936 · 1 comment ·
Maintainers usually reply within 3 days
-
Update toast stylingOpendesign good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
scribe-org/Scribe-Android#778 ·
Maintainers usually reply within 1 day
-
AI Generated CI/CD ⚒️ Flaky-tests 🐦 go 🏃
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
valkey-io/valkey-glide#7772 ·
Maintainers usually reply within 1 day
-
Error Handling Swift
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Automattic/wordpress-rs#1759 ·
Maintainers usually reply within 1 day