Add Note restored after its note type was deleted bounces to the deck list

Open
#23,359 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
63/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
android, kotlin
Domain
mobile

Research direction

Start with the regression test in AnkiDroid/src/test/java/com/ichi2/anki/NoteEditorMissingNoteTypeTest.kt and trace how NoteEditorActivity restores Add Note state after the selected note type is removed. Run the test to reproduce the bounce to the deck list; done means restoration opens the editor with an existing note type and does not launch another activity. The issue notes this may need to be split from the linked PR.

Written by the indexing model from the issue text.

Description

Assisted-by: Claude Opus 5.5 max

Subject: [EXISTING] Add Note restored after its note type was deleted bounces to the deck list

Add Note recreated after its note type is deleted hits the linked issue's error and silently opens the deck list instead of falling back.

⚠️ This issue existed before the PR and should likely be split off into a separate issue.

---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/NoteEditorMissingNoteTypeTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/NoteEditorMissingNoteTypeTest.kt
new file mode 100644
index 0000000000..2014769dc8
--- /dev/null
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/NoteEditorMissingNoteTypeTest.kt
@@ -0,0 +1,40 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+package com.ichi2.anki
+
+import androidx.test.core.app.ActivityScenario
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.ichi2.anki.common.destinations.NoteEditorDestination
+import com.ichi2.anki.common.destinations.toIntent
+import com.ichi2.anki.noteeditor.getNoteEditorFragment
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.Shadows.shadowOf
+import kotlin.test.assertNotNull
+import kotlin.test.assertNull
+
+@RunWith(AndroidJUnit4::class)
+class NoteEditorMissingNoteTypeTest : RobolectricTest() {
+    @Test
+    fun `restoring Add Note after its note type was deleted falls back to an existing note type`() {
+        ensureCollectionLoadIsSynchronous()
+        val name = addStandardNoteType("Deleted Later", arrayOf("Front", "Back"), "{{Front}}", "{{Back}}")
+        val type = col.notetypes.byName(name)!!
+
+        ActivityScenario.launch<NoteEditorActivity>(NoteEditorDestination.AddNote().toIntent()).use { scenario ->
+            scenario.onActivity { it.getNoteEditorFragment().setCurrentlySelectedNoteType(type.id) }
+            advanceRobolectricLooper()
+            col.notetypes.remove(type.id)
+
+            scenario.recreate()
+            advanceRobolectricLooper()
+
+            scenario.onActivity { activity ->
+                val opened = shadowOf(activity).nextStartedActivity?.component?.className
+                assertNull(opened, "the editor gave up and opened $opened")
+                val restoredNoteTypeId = activity.getNoteEditorFragment().editorNote?.noteTypeId
+                assertNotNull(restoredNoteTypeId?.let { col.notetypes.get(it) }, "restored note type $restoredNoteTypeId does not exist")
+            }
+        }
+    }
+}

Originally posted by @criticalAY in https://github.com/ankidroid/Anki-Android/pull/23077#pullrequestreview-5930134433

Dominant language
Kotlin
Stars
12.3k
Forks
3.1k
Avg merge
1d 11h
Merged PRs (30d)
383

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ankidroid/Anki-Android

All issues in ankidroid/Anki-Android

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.