Back exits DeckPicker after tablet recreation
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 58/100
Research direction
Start from AnkiDroid/src/test/java/com/ichi2/anki/DeckPickerPaneBackPriorityTest.kt: the added test recreates DeckPicker, opens reminders, and asserts Back does not finish the activity. Run that test in isolation first, then trace how DeckPicker registers its back callback and restores the reminders fragment after recreate(). Done means the new test passes and Back from reminders returns to Study Options rather than exiting DeckPicker.
Written by the indexing model from the issue text.
Description
Assisted-by: GPT-6.1-Sol xhigh
Patch order: this patch follows the overlay regression patch liked in the PR.
Subject: [EXISTING] Back exits DeckPicker after tablet recreation
After tablet recreation, opening reminders and pressing Back closes DeckPicker instead of returning to Study Options.
⚠️ This issue existed before the PR and should likely be split off into a separate issue.
---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/DeckPickerPaneBackPriorityTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/DeckPickerPaneBackPriorityTest.kt
index 3fc345c9e02fb061b0d3f36c4509c2fdb09d3462..574bac4cfabff4ac216aa908fc37910db1b494c0 100644
--- a/AnkiDroid/src/test/java/com/ichi2/anki/DeckPickerPaneBackPriorityTest.kt
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/DeckPickerPaneBackPriorityTest.kt
@@ -77,6 +77,24 @@ class DeckPickerPaneBackPriorityTest : RobolectricTest() {
assertFalse(activity.isFinishing)
}
+ @Test
+ fun `back returns from reminders after tablet recreation`() {
+ val controller = launchStudyOptions()
+ controller.recreate()
+ val activity = controller.get()
+ activity.viewModel.awaitStartup()
+ advanceRobolectricLooper()
+ assertNotNull(activity.fragment)
+ openReminders(activity)
+
+ activity.onBackPressedDispatcher.onBackPressed()
+ advanceRobolectricLooper()
+
+ assertFalse(activity.isFinishing, "Back must return to study options rather than close DeckPicker")
+ assertNotNull(activity.fragment)
+ assertTrue(reminders(activity) == null)
+ }
+
private fun launchWithReminders(): DeckPicker {
val activity = launchStudyOptions().get()
openReminders(activity)
Originally posted by @david-allison in https://github.com/ankidroid/Anki-Android/pull/22755#pullrequestreview-5912122550
- Dominant language
- Kotlin
- Stars
- 12.3k
- Forks
- 3.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 383
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ankidroid/Anki-Android
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23392 ·
Maintainers usually reply within 1 day
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23390 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23385 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23374 ·
Maintainers usually reply within 1 day
-
Selected custom-study tags become unreadablePossibly taken @chesh-ire claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ankidroid/Anki-Android#23352 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in ankidroid/Anki-Android
Similar issues
-
Bug Domain changed
Difficulty 1/5 Under an hour Newbie friendliness 79/100
keiyoushi/extensions-source#21174 ·
Maintainers usually reply within 1 day
-
Unified account interface not translated into Simplified ChinesePossibly taken @xuenhua claimed this 3 days ago. Openunconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
thunderbird/thunderbird-android#11936 · 1 comment ·
Maintainers usually reply within 3 days
-
Update toast stylingOpendesign good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
scribe-org/Scribe-Android#778 ·
Maintainers usually reply within 1 day
-
AI Generated CI/CD ⚒️ Flaky-tests 🐦 go 🏃
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
valkey-io/valkey-glide#7772 ·
Maintainers usually reply within 1 day
-
Error Handling Swift
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Automattic/wordpress-rs#1759 ·
Maintainers usually reply within 1 day