Browser: some issues with actions

Open
#23,277 1 comment 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
android, kotlin
Domain
mobile

Research direction

The payload names no files, so start by finding the card browser's action handlers (flag, suspend, bury, note type change, deck change, reposition, due date, grade, reset progress, find and replace) and compare how each one refreshes rows and clears selection. Pick one failing action, such as flagging or reset progress, and confirm the bug by reproducing it. Done means each action behaves consistently, with no trailing periods in the snackbar strings, and the selection behavior is agreed with maintainers first because the thread leaves it open.

Written by the indexing model from the issue text.

Description

These are a bit verbose, but they boil down to a few differences. I also mentioned the working actions for completeness.

I can split them up if you want.

  • Flagging doesn't work.
  • Edit note works.
  • Card info works.
  • Toggle mark works and doesn't remove the selection.
  • Toggle suspend works and removes the selection. An "x cards shown" snackbar appears.
  • Toggle bury works but the rows don't change their color and it doesn't remove the selection. An undo snackbar is shown with the string "x cards buried." (notice the period).
  • Changing note types works but the rows don't update and it doesn't remove the selection. A "x notes updated." snackbar appears (notice the period).
  • Changing the deck works the rows don't update and it doesn't remove the selection. An undo snackbar appears with the string "x cards updated." (notice the period).
  • Reposition works but the rows don't update and it doesn't remove the selection. A "Changed position of x new cards." snackbar appears (notice the period).
  • Set due date works but the rows don't update and it doesn't remove the selection. A "Set due date of x cards." snackbar appears (notice the period).
  • Editing tags works and removes the selection. An "x cards shown" snackbar appears.
  • Grade now works but the rows don't update and it doesn't remove the selection. An undo snackbar with the string "Graded x cards." (notice the period).
  • Delete note works.
  • Reset progress doesn't work.
  • Find & replace doesn't work.
Expected behavior
  • They all work.
  • The selection is not removed if possible.
    • This is tricky. Anki Desktop doesn't update the browser after changes so the selections remain. So it's a balance between updating the card browser and keeping the selection.
  • Each actions shows an undo snackbar or none of them does.
  • No periods in strings.
Dominant language
Kotlin
Stars
12.3k
Forks
3.1k
Avg merge
1d 11h
Merged PRs (30d)
383

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ankidroid/Anki-Android

All issues in ankidroid/Anki-Android

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.