Undoing a tag rename leaves an unused destination parent
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
Research direction
Start with ManageTagsViewModel.renameTag and the expansion restoration path; the issue says parent creation occurs outside undo history and points to a backend transaction change. Read the new ManageTagsRenameUndoRegressionTest.kt and run that regression test to reproduce the problem. Done means undo restores the original note tags and removes the unused destination parent from the tag cache.
Written by the indexing model from the issue text.
Description
Assisted-by: GPT-6.1-Sol xhigh & GPT-6-Astra xhigh
Undoing a tag rename leaves an unused destination parent
Subject: Undoing a tag rename leaves an unused destination parent
Undoing an expanded branch rename restores note tags but leaves the destination parent in the tag list, blocking later renames to that name.
Fix unresolved: no compatible temporary fix verified.
Expansion restoration creates the parent outside undo history; preserving its creation and expansion together requires a backend transaction change.
---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/tags/ManageTagsRenameUndoRegressionTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/tags/ManageTagsRenameUndoRegressionTest.kt
new file mode 100644
index 0000000000..d587b1d8ee
--- /dev/null
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/tags/ManageTagsRenameUndoRegressionTest.kt
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+package com.ichi2.anki.tags
+
+import com.ichi2.testutils.JvmTest
+import com.ichi2.testutils.rules.IcuCaseFoldingRule
+import com.ichi2.testutils.withViewModel
+import org.junit.Rule
+import org.junit.Test
+import kotlin.test.assertEquals
+
+class ManageTagsRenameUndoRegressionTest : JvmTest() {
+ @get:Rule
+ val caseFolding = IcuCaseFoldingRule()
+
+ @Test
+ fun `undoing an expanded branch rename removes the destination from the tag cache`() =
+ runTest {
+ val source = requireNotNull(TagName.build("source"))
+ val destination = requireNotNull(TagName.build("destination"))
+ val note = addBasicNote().update { addTag("source::child") }
+ withViewModel(ManageTagsViewModel()) {
+ toggleCollapsed(source).join()
+ val originalTags = col.tags.all().sorted()
+ renameTag(source, destination).join()
+ assertEquals(listOf("destination::child"), col.getNote(note.id).tags)
+
+ col.undo()
+
+ assertEquals(listOf("source::child"), col.getNote(note.id).tags)
+ assertEquals(originalTags, col.tags.all().sorted(), "Undo must also remove the unused destination parent")
+ }
+ }
+}
Originally posted by @david-allison in https://github.com/ankidroid/Anki-Android/pull/22849#pullrequestreview-5875867983
- Dominant language
- Kotlin
- Stars
- 12.3k
- Forks
- 3.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 383
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ankidroid/Anki-Android
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23392 ·
Maintainers usually reply within 1 day
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23390 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23385 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23374 ·
Maintainers usually reply within 1 day
-
Selected custom-study tags become unreadablePossibly taken @chesh-ire claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ankidroid/Anki-Android#23352 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in ankidroid/Anki-Android
Similar issues
-
Bug Domain changed
Difficulty 1/5 Under an hour Newbie friendliness 79/100
keiyoushi/extensions-source#21174 ·
Maintainers usually reply within 1 day
-
Unified account interface not translated into Simplified ChinesePossibly taken @xuenhua claimed this 3 days ago. Openunconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
thunderbird/thunderbird-android#11936 · 1 comment ·
Maintainers usually reply within 3 days
-
Update toast stylingOpendesign good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
scribe-org/Scribe-Android#778 ·
Maintainers usually reply within 1 day
-
AI Generated CI/CD ⚒️ Flaky-tests 🐦 go 🏃
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
valkey-io/valkey-glide#7772 ·
Maintainers usually reply within 1 day
-
Error Handling Swift
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Automattic/wordpress-rs#1759 ·
Maintainers usually reply within 1 day