Manage Tags: Stale tag hierarchy after external updates
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
Research direction
Start with the regression test in AnkiDroid/src/test/java/com/ichi2/anki/tags/ManageTagsRefreshRegressionTest.kt and the referenced PR review for context. Trace how ManageTagsViewModel prepares renames and refreshes tag state when ChangeManager publishes external updates. Done means the test confirms collision checks use the updated tag hierarchy and prevent an unintended merge.
Written by the indexing model from the issue text.
Description
Subject: [EXISTING] Stale tag hierarchy after external updates
An API tag update during rename preparation leaves collision checks stale, allowing an unintended merge through the new rename dialog.
⚠️ This issue existed before the PR and should likely be split off into a separate issue.
---
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/tags/ManageTagsRefreshRegressionTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/tags/ManageTagsRefreshRegressionTest.kt
new file mode 100644
index 0000000000..9ce0b14e02
--- /dev/null
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/tags/ManageTagsRefreshRegressionTest.kt
@@ -0,0 +1,48 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+package com.ichi2.anki.tags
+
+import com.ichi2.anki.CollectionManager
+import com.ichi2.anki.observability.ChangeManager
+import com.ichi2.testutils.JvmTest
+import com.ichi2.testutils.rules.IcuCaseFoldingRule
+import com.ichi2.testutils.withViewModel
+import kotlinx.coroutines.CoroutineStart
+import kotlinx.coroutines.async
+import kotlinx.coroutines.test.StandardTestDispatcher
+import org.junit.Rule
+import org.junit.Test
+import kotlin.test.assertEquals
+import kotlin.test.assertTrue
+
+class ManageTagsRefreshRegressionTest : JvmTest() {
+ @get:Rule
+ val caseFolding = IcuCaseFoldingRule()
+
+ @Test
+ fun `external tag changes during rename preparation invalidate collision checks`() =
+ runTest {
+ val source = requireNotNull(TagName.build("source"))
+ val destination = requireNotNull(TagName.build("destination"))
+ val note = addBasicNote().update { addTag(source.value) }
+ val collection = col
+ withViewModel(ManageTagsViewModel()) {
+ assertTrue(tagExists(source))
+ val previousQueue = CollectionManager.setTestDispatcher(StandardTestDispatcher(testScheduler), useReentrantLock = false)
+ try {
+ val preparation = async(start = CoroutineStart.UNDISPATCHED) { prepareRename(source) }
+ assertTrue((state.value as ManageTagsState.Content).isWorking)
+ // An API batch can publish changes while the eligibility query is queued.
+ collection.getNote(note.id).also {
+ it.addTag(destination.value)
+ collection.updateNote(it)
+ }
+ ChangeManager.notifySubscribersAllValuesChanged()
+ assertEquals(true, preparation.await())
+ assertEquals(TagInputValidation.ALREADY_EXISTS, validateTagRename(source, destination.value, ::tagExists))
+ } finally {
+ CollectionManager.setTestDispatcher(previousQueue)
+ }
+ }
+ }
+}
https://github.com/ankidroid/Anki-Android/pull/22849#pullrequestreview-5875194447
- Dominant language
- Kotlin
- Stars
- 12.3k
- Forks
- 3.1k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 383
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ankidroid/Anki-Android
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23392 ·
Maintainers usually reply within 1 day
-
Needs Triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ankidroid/Anki-Android#23390 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23385 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
ankidroid/Anki-Android#23374 ·
Maintainers usually reply within 1 day
-
Selected custom-study tags become unreadablePossibly taken @chesh-ire claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ankidroid/Anki-Android#23352 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in ankidroid/Anki-Android
Similar issues
-
Bug Domain changed
Difficulty 1/5 Under an hour Newbie friendliness 79/100
keiyoushi/extensions-source#21174 ·
Maintainers usually reply within 1 day
-
Unified account interface not translated into Simplified ChinesePossibly taken @xuenhua claimed this 3 days ago. Openunconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
thunderbird/thunderbird-android#11936 · 1 comment ·
Maintainers usually reply within 3 days
-
Update toast stylingOpendesign good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
scribe-org/Scribe-Android#778 ·
Maintainers usually reply within 1 day
-
AI Generated CI/CD ⚒️ Flaky-tests 🐦 go 🏃
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
valkey-io/valkey-glide#7772 ·
Maintainers usually reply within 1 day
-
Error Handling Swift
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Automattic/wordpress-rs#1759 ·
Maintainers usually reply within 1 day