Schedule a weekly job to showcase screenshot changes

Open
#23,206 0 comments 2 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
android, github-actions, kotlin
Domain
ci-cd, testing

Research direction

Start by locating the existing CI workflow that captures screenshots and produces per-PR visual diffs; the issue does not name a workflow or test file. Work out how to compare the current main branch with its state from seven days earlier, then schedule the job for Wednesdays and upload the generated diff zip as an artifact. Done means the scheduled run creates that artifact; how to notify maintainers is explicitly deferred.

Written by the indexing model from the issue text.

Description

https://discord.com/channels/368267295601983490/701922522836369498/1570210391907377185

Every Wednesday, run a CI job that compares main against main, 7 days ago so we have a full check for visual regressions that may have been missed

David

don't we do that on every PR?

Brayan

We're going VERY fast with theming right now
Yes, but a weekly snapshot, rather than a per-PR snapshot

David

or maybe do you want to account the combination of merged PRs?
e.g. you add a new component in a PR
I change a color in another PR
screenshots were based on main
then I change your new component by accident

Brayan

Not just that, but also organizational
Adding a small ritual of going through all visual changes in the week, as a quality gate.
The upside of catching visual regressions is high, the time that it takes to perform the check is minimal

David

do that on releases?
or block releases if there are sudden visual changes

Brayan

Process-gating a release sucks.
It gets skipped when a release is needed immediately, and that's when it matters most that we're confident in the release.

David

once a week works
make it create an issue if there are changes?
ping the maintainers?

Brayan


For now, just generate the diff zip and upload it as an artifact, we can decide on how to expose this to users/maintainers at a later date

Dominant language
Kotlin
Stars
12.3k
Forks
3.1k
Avg merge
1d 11h
Merged PRs (30d)
383

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ankidroid/Anki-Android

All issues in ankidroid/Anki-Android

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.