[BUG] get_dependencies in nuget.py crashes with KeyError: '@targetFramework' on dependency groups without targetFramework

Open
#5,493 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

@patelshivani2283-lab is already working on this.

Since Nov 17, 2026.

  • #5494 by @patelshivani2283-lab — open

Assessment

Difficulty
4/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start with get_dependencies() in src/packagedcode/nuget.py and inspect the existing NuGet package tests for .nuspec dependency groups and license parsing. The issue also reports that packages.lock.json project references of type Project are rejected; check the related lockfile handling and tests. Reproduce the fallback group crash, then confirm all three reported cases are covered and scans complete without errors.

Written by the indexing model from the issue text.

Description

Description

In NuGet .nuspec manifests, dependency <group> elements can specify target frameworks. According to Microsoft's NuGet nuspec reference documentation:

"A <dependencies> element can contain one <group> tag without a targetFramework attribute to specify a fallback group that is applied when no specific targetFramework matches the project."

Currently, scancode-toolkit's get_dependencies() in src/packagedcode/nuget.py accesses group['@targetFramework'] directly:

for group in groups:
    extra_data = dict(framework=group['@targetFramework'])
    deps = group.get('dependency') or []
    yield from _get_dep_packs(deps, extra_data)

When scanning any .nuspec that includes a fallback <group> without targetFramework, this raises an unhandled KeyError: '@targetFramework' and aborts the scan.

Additionally:

  • When <license type="expression">...</license> is used in .nuspec, xmltodict parses the element as a dictionary ({'@type': 'expression', '#text': '...'}). Because nuspec.get('license') was passed directly, extracted_license_statement received the dictionary, resulting in a stringified mapping rather than extracting the license expression string.
  • In packages.lock.json, project references with "type": "Project" were not recognized, raising Exception: Unknown package type: Project.
How To Reproduce
  1. Create a test.nuspec with a fallback group:
<?xml version="1.0"?>
<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
  <metadata>
    <id>SamplePackage</id>
    <version>1.0.0</version>
    <dependencies>
      <group>
        <dependency id="FallbackDep" version="1.0.0" />
      </group>
      <group targetFramework="net6.0">
        <dependency id="Net6Dep" version="2.0.0" />
      </group>
    </dependencies>
  </metadata>
</package>
  1. Scan the file:
./scancode --package --json - test.nuspec
  1. Observe traceback:
KeyError: '@targetFramework'
Expected Behavior
  • Dependencies in a fallback <group> without targetFramework should be extracted without crashing.
  • extra_data['framework'] should be set when targetFramework is present, or omitted when absent.
  • The <license> element text should be cleanly extracted even when attributes like type="expression" are present.
System configuration
  • OS: macOS / Linux / Windows
  • ScanCode version: 33.0.0rc1 / develop branch
  • Python version: 3.10+
Dominant language
Python
Stars
2.7k
Forks
871
Avg merge
1d 10h
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aboutcode-org/scancode-toolkit

All issues in aboutcode-org/scancode-toolkit

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.