SPDX validation should consider arbitrary expressions in format `<KNOWN-LICENSE-ID>"+"` as valid
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start by reproducing the get_spdx_licensing().validate() examples for CDDL-1.0+ and MIT OR CDDL-1.0+, then trace how the parser and validator handle license keys. Done means both expressions validate without errors and produce normalized expressions that retain the trailing +.
Written by the indexing model from the issue text.
Description
SPDX license expression allow the following Simple license expressions:
An SPDX License List Short Form Identifier with a unary "+" operator suffix to represent the current version of the license or any later version. For example:
CDDL-1.0+
spec & docs:
- https://spdx.github.io/spdx-spec/v3.0.1/annexes/spdx-license-expressions/#simple-license-expressions
- https://spdx.github.io/spdx-spec/v2.3/SPDX-license-expressions/#d3-simple-license-expressions
request
make the validator and parser support SPDX License Identifiers with a + at the end.
reproduce
I tested with exactly this example CDDL-1.0+ value, but got a negative, where I expected a positive:
tested with license-expression==30.4.1
>>> from license_expression import get_spdx_licensing
>>> lic = get_spdx_licensing()
>>> lic.validate('CDDL-1.0')
ExpressionInfo(
original_expression='CDDL-1.0',
normalized_expression='CDDL-1.0',
errors=[],
invalid_symbols=[]
)
>>> lic.validate('CDDL-1.0+')
ExpressionInfo(
original_expression='CDDL-1.0+',
normalized_expression=None,
errors=['Unknown license key(s): CDDL-1.0+'],
invalid_symbols=['CDDL-1.0+']
)
>>> lic.validate('MIT OR CDDL-1.0+')
ExpressionInfo(
original_expression='MIT OR CDDL-1.0+',
normalized_expression=None,
errors=['Unknown license key(s): CDDL-1.0+'],
invalid_symbols=['CDDL-1.0+']
)
- Dominant language
- Python
- Stars
- 74
- Forks
- 38
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aboutcode-org/license-expression
-
Bump setuptools dependency and remove wheel dependencyPossibly taken @devnishantt claimed this 51 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 83/100
aboutcode-org/license-expression#132 · 1 comment ·
-
Difficulty 3/5 Half a day Newbie friendliness 55/100
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
aboutcode-org/license-expression#124 · 3 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
aboutcode-org/license-expression#121 · 5 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
aboutcode-org/license-expression#120 · 2 comments · 1 reaction ·
All issues in aboutcode-org/license-expression
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
mohanraj00/entelos#200 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
sweep
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
bketelsen/truenas-mcp#77 ·
Maintainers usually reply within 1 day
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
sandbox-quantum/switch#2163 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
openedx/xblock-lti-consumer#765 ·
Maintainers usually reply within 1 day