Valid licence expressions flagged as invalid

Open
#143 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
tooling

Research direction

The issue gives three expressions that should validate: "MIT OR GPL-2.0-or-later OR (FSFUL AND BSD-2-Clause)", "(FSFUL AND BSD-2-Clause)" and "FSFUL AND BSD-2-Clause". Reproduce them in a Python shell against the library's validation call to confirm that only the parenthesized forms fail. Then find where parentheses are handled in the parser and check the existing tests for similar cases. Done means all three expressions validate and a regression test covers the parenthesized cases.

Written by the indexing model from the issue text.

Description

Valid licence expressions like "MIT OR GPL-2.0-or-later OR (FSFUL AND BSD-2-Clause)" are flagged as invalid.

Same for "(FSFUL AND BSD-2-Clause)"

"FSFUL AND BSD-2-Clause" is flagged as valid.

Dominant language
Python
Stars
74
Forks
38
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aboutcode-org/license-expression

All issues in aboutcode-org/license-expression

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.