Simplification drops essential parts of expressions
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 52/100
Research direction
Reproduce the two examples with license_expression, focusing first on the parse() and simplify() entry points named in the report. Trace why the OR sections disappear from the simplified expression, then add or update coverage for these cases so simplification preserves choices that have not been exercised.
Written by the indexing model from the issue text.
Description
I am using the license-expression library to feed it a large string of licenses from different package files to propose a derived package license. Unfortunately, this approach omits important licenses.
Let's consider the following example:
>>> from license_expression import get_spdx_licensing
>>> licensing = get_spdx_licensing()
>>> expression = "MIT AND BSD-3-Clause AND (MIT OR GPL-2.0-or-later OR (Apache-2.0 AND BSD-2-Clause)) AND MIT"
>>> parsed = licensing.parse(expression)
>>> str(parsed.simplify())
BSD-3-Clause AND MIT
>>> expression = "MIT AND BSD-3-Clause AND (MIT OR GPL-2.0-or-later OR Apache-2.0) AND MIT"
>>> parsed = licensing.parse(expression)
>>> str(parsed.simplify())
BSD-3-Clause AND MIT
As we can see, the whole OR sections have been removed, which would imply I already exercised a choice, which is not the case.
- Dominant language
- Python
- Stars
- 74
- Forks
- 38
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aboutcode-org/license-expression
-
Bump setuptools dependency and remove wheel dependencyPossibly taken @devnishantt claimed this 51 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 83/100
aboutcode-org/license-expression#132 · 1 comment ·
-
Difficulty 3/5 Half a day Newbie friendliness 55/100
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
aboutcode-org/license-expression#121 · 5 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
aboutcode-org/license-expression#120 · 2 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
aboutcode-org/license-expression#111 · 4 comments ·
All issues in aboutcode-org/license-expression
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
mohanraj00/entelos#200 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
sweep
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
bketelsen/truenas-mcp#77 ·
Maintainers usually reply within 1 day
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
sandbox-quantum/switch#2163 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
openedx/xblock-lti-consumer#765 ·
Maintainers usually reply within 1 day