Undefined behavior in Plat_IsInDebugSession
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- cpp
- Domain
- operating-systems
Research direction
Start in src/tier0/dbg.cpp at Plat_IsInDebugSession and inspect the IsPlaystation() preprocessor branch, then check the PS5 project configuration and available platform implementations. Confirm the replacement behavior with the PS5 build or tests, and consider the issue done when the function returns a defined result without introducing platform-specific build failures.
Written by the indexing model from the issue text.
Description
Hello,
While debugging the PlayStation build, we noticed undefined behavior in Plat_IsInDebugSession. It seems that the NDA material has been removed but is missing a replacement in the ps5 project.
https://github.com/ValveSoftware/GameNetworkingSockets/blob/partner/src/tier0/dbg.cpp#L121
bool Plat_IsInDebugSession()
{
...
#elif IsPlaystation()
// NDA material << does not return any value
#elif IsNintendoSwitch()
return false;
#else
#error "HALP"
#endif
}
- Dominant language
- C++
- Stars
- 9.9k
- Forks
- 749
- Avg merge
- 5d 19h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ValveSoftware/GameNetworkingSockets
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ValveSoftware/GameNetworkingSockets#425 · 7 comments ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 48/100
ValveSoftware/GameNetworkingSockets#399 · 2 comments ·
All issues in ValveSoftware/GameNetworkingSockets
Similar issues
-
upstream update
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
conan-io/conan-center-index#31098 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
bug chart-audit
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
godotengine/godot#124120 ·
Maintainers usually reply within 1 day
-
Component: R Type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
apache/arrow#51695 · 1 comment ·
Maintainers usually reply within 1 day