Linux client has invalid XDG toplevel app id

Open Beginner friendly
  • Is something wrong?
#1,728 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

A pull request for this has already been merged.

  • #1730 by @SkyJoshua — merged

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, linux
Domain
desktop

Research direction

The payload does not name the file that sets the app id, so start by searching the Linux desktop client for where the Wayland toplevel app id is set to Valour. Confirm that a matching gg.valour.Valour.desktop entry exists or is expected to ship with the client. Done when the app id is gg.valour.Valour, which you can check with WAYLAND_DEBUG=1 or a compositor tool, and the KDE icon and window rules behave as the issue describes.

Written by the indexing model from the issue text.

Description

Describe the bug
The app id on wayland needs to match the name of the desktop file so that compositors/DEs can properly identify the application. It's currently registered as Valour when it should be gg.valour.Valour. An improper app id can result in strange behavior and handling of the application, for example, on KDE the app icon in every place except the task bar appears as the default wayland logo, and reportedly on Gnome this can cause window matching rules to fail.

To Reproduce
Steps to reproduce the behavior:

  1. Open linux application
  2. Check app id either through logging (WAYLAND_DEBUG=1) or compositor tools (hyprctl, Kwin Debug Console, etc.)

Expected behavior
IDs should match

Screenshots
Image

System Information:

  • OS: Linux
  • Valour Version: 0.9.19
  • Valour Platform: Desktop

Additional context

The compositor shell will try to group application surfaces together by their app ID. As a best practice, it is suggested to select app ID's that match the basename of the application's .desktop file. For example, "org.freedesktop.FooViewer" where the .desktop file is "org.freedesktop.FooViewer.desktop".

https://wayland.app/protocols/xdg-shell#xdg_toplevel:request:set_app_id

Dominant language
C#
Stars
411
Forks
41
Avg merge
4d 18h
Merged PRs (30d)
8

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Valour-Software/Valour

All issues in Valour-Software/Valour

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.