analyze: archive name is the bare file name, so same-named bundles in different folders are skipped as duplicates
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 65/100
Research direction
The issue is in the analyze command and SerializedFileParser.Parse. Start by examining the code that calculates the archive name, likely in the parser where Path.GetRelativePath is called. The root directory needs to be passed through. Check the schema documentation and update the archives.name field. Write a test that creates two bundles with the same name in different subfolders and verifies both are recorded. Run existing tests to ensure no regression.
Written by the indexing model from the issue text.
Description
Problem
analyze records archives.name as the bare file name of the bundle, not its path relative to the scanned directory. SerializedFileParser.Parse passes the file's own directory as the root, so Path.GetRelativePath(root, file) always collapses to the file name. The schema requires archive names to be unique, so two bundles with the same file name in different folders are treated as a duplicate build and the second one is skipped:
Skipping dlc\limitedtimeoffers\offer2\all: Duplicate archive name 'all'. Each analyzed archive must have a unique name; only a single build can be analyzed at a time.
This blocks analyzing real BuildPipeline.BuildAssetBundles output where bundle names are paths. Bundle names like dlc/<item>/all are legal and common (the AssetBundle name is a path, and the build writes the folder structure to disk). In a 54,000 bundle customer build almost every item folder contains an all bundle, so analyze over any folder with more than one item fails nearly every bundle:
Finalizing database. Successfully processed files: 279, Failed files: 16309, ...
The same thing happens with -p "*.en-us" over a tree of AssetBundle variants: all 3,353 matching files are called localizedui.en-us and only the first is analyzed.
The current work-around is to copy the bundles into a flat folder with the relative path encoded in the file name (dlc__limitedtimeoffers__offer2__all), which is slow and awkward for multi-GB builds.
Why this is fixable
References between bundles never use the archive name. A PPtr resolves through the SerializedFile's external reference table, which names the target by its internal CAB-<hash> path. analyze already keys references on the SerializedFile name, so the archive name is only a label for the user. Recording the path relative to the scanned root (for example dlc/limitedtimeoffers/offer2/all) keeps names unique whenever the build itself is unique, and matches the name Unity gives the bundle in the AssetBundleManifest, which makes joining against manifest data easier.
Proposed change
- Pass the scanned root through to
SerializedFileParsersoarchives.namebecomes the path relative to that root, with/separators. A file passed directly on the command line keeps its file name, as today. - Keep the
Duplicate archive namemessage for genuine duplicates (two builds with the same relative layout). - Document the change in
Documentation/analyzer-schema.md(archives.name) andDocumentation/command-analyze.md. Thearchivecolumn inobject_viewchanges value for nested bundles, so bumpPRAGMA user_versionand add a row to the schema version table. - Add a test with two bundles of the same file name in different sub-folders of one scanned directory, asserting both archives are recorded with distinct path-based names and that references between them still resolve.
Related: #51 introduced the duplicate-name handling.
- Dominant language
- C#
- Stars
- 821
- Forks
- 71
- Avg merge
- 4h 54m
- Merged PRs (30d)
- 10
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Unity-Technologies/UnityDataTools
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Unity-Technologies/UnityDataTools#116 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
All issues in Unity-Technologies/UnityDataTools
Similar issues
-
Documentation
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cake-build/cake#5024 ·
-
Frontend status/draft TechnicalDebt
Difficulty 2/5 1-2 days Newbie friendliness 75/100
Altinn/altinn-auth#4143 ·
-
.NET Flaky Test Testing Tests
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
getsentry/sentry-dotnet#5617 · 1 comment ·
-
:watch: Not Triaged dotnet-fsharp/svc
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Client customer-reported needs-team-attention question Service Attention WebPubSub
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Azure/azure-sdk-for-net#63292 · 3 comments · 1 reaction ·