Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

analyze: archive name is the bare file name, so same-named bundles in different folders are skipped as duplicates

オープン
#149 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
65/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
csharp, unity
領域
data, tooling

調査の方向性

The issue is in the analyze command and SerializedFileParser.Parse. Start by examining the code that calculates the archive name, likely in the parser where Path.GetRelativePath is called. The root directory needs to be passed through. Check the schema documentation and update the archives.name field. Write a test that creates two bundles with the same name in different subfolders and verifies both are recorded. Run existing tests to ensure no regression.

索引モデルが issue の本文から書いたものです。

説明

bug

Problem

analyze records archives.name as the bare file name of the bundle, not its path relative to the scanned directory. SerializedFileParser.Parse passes the file's own directory as the root, so Path.GetRelativePath(root, file) always collapses to the file name. The schema requires archive names to be unique, so two bundles with the same file name in different folders are treated as a duplicate build and the second one is skipped:

Skipping dlc\limitedtimeoffers\offer2\all: Duplicate archive name 'all'. Each analyzed archive must have a unique name; only a single build can be analyzed at a time.

This blocks analyzing real BuildPipeline.BuildAssetBundles output where bundle names are paths. Bundle names like dlc/<item>/all are legal and common (the AssetBundle name is a path, and the build writes the folder structure to disk). In a 54,000 bundle customer build almost every item folder contains an all bundle, so analyze over any folder with more than one item fails nearly every bundle:

Finalizing database. Successfully processed files: 279, Failed files: 16309, ...

The same thing happens with -p "*.en-us" over a tree of AssetBundle variants: all 3,353 matching files are called localizedui.en-us and only the first is analyzed.

The current work-around is to copy the bundles into a flat folder with the relative path encoded in the file name (dlc__limitedtimeoffers__offer2__all), which is slow and awkward for multi-GB builds.

Why this is fixable

References between bundles never use the archive name. A PPtr resolves through the SerializedFile's external reference table, which names the target by its internal CAB-<hash> path. analyze already keys references on the SerializedFile name, so the archive name is only a label for the user. Recording the path relative to the scanned root (for example dlc/limitedtimeoffers/offer2/all) keeps names unique whenever the build itself is unique, and matches the name Unity gives the bundle in the AssetBundleManifest, which makes joining against manifest data easier.

Proposed change

  • Pass the scanned root through to SerializedFileParser so archives.name becomes the path relative to that root, with / separators. A file passed directly on the command line keeps its file name, as today.
  • Keep the Duplicate archive name message for genuine duplicates (two builds with the same relative layout).
  • Document the change in Documentation/analyzer-schema.md (archives.name) and Documentation/command-analyze.md. The archive column in object_view changes value for nested bundles, so bump PRAGMA user_version and add a row to the schema version table.
  • Add a test with two bundles of the same file name in different sub-folders of one scanned directory, asserting both archives are recorded with distinct path-based names and that references between them still resolve.

Related: #51 introduced the duplicate-name handling.

主要言語
C#
スター
821
フォーク
71
平均マージ
4時間 54分
マージ済み PR(30日)
10

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Unity-Technologies/UnityDataTools のほかの issue

Unity-Technologies/UnityDataTools の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。