Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

analyze: archive name is the bare file name, so same-named bundles in different folders are skipped as duplicates

Ouverte
#149 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
65/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
csharp, unity
Domaine
data, tooling

Piste de recherche

The issue is in the analyze command and SerializedFileParser.Parse. Start by examining the code that calculates the archive name, likely in the parser where Path.GetRelativePath is called. The root directory needs to be passed through. Check the schema documentation and update the archives.name field. Write a test that creates two bundles with the same name in different subfolders and verifies both are recorded. Run existing tests to ensure no regression.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Problem

analyze records archives.name as the bare file name of the bundle, not its path relative to the scanned directory. SerializedFileParser.Parse passes the file's own directory as the root, so Path.GetRelativePath(root, file) always collapses to the file name. The schema requires archive names to be unique, so two bundles with the same file name in different folders are treated as a duplicate build and the second one is skipped:

Skipping dlc\limitedtimeoffers\offer2\all: Duplicate archive name 'all'. Each analyzed archive must have a unique name; only a single build can be analyzed at a time.

This blocks analyzing real BuildPipeline.BuildAssetBundles output where bundle names are paths. Bundle names like dlc/<item>/all are legal and common (the AssetBundle name is a path, and the build writes the folder structure to disk). In a 54,000 bundle customer build almost every item folder contains an all bundle, so analyze over any folder with more than one item fails nearly every bundle:

Finalizing database. Successfully processed files: 279, Failed files: 16309, ...

The same thing happens with -p "*.en-us" over a tree of AssetBundle variants: all 3,353 matching files are called localizedui.en-us and only the first is analyzed.

The current work-around is to copy the bundles into a flat folder with the relative path encoded in the file name (dlc__limitedtimeoffers__offer2__all), which is slow and awkward for multi-GB builds.

Why this is fixable

References between bundles never use the archive name. A PPtr resolves through the SerializedFile's external reference table, which names the target by its internal CAB-<hash> path. analyze already keys references on the SerializedFile name, so the archive name is only a label for the user. Recording the path relative to the scanned root (for example dlc/limitedtimeoffers/offer2/all) keeps names unique whenever the build itself is unique, and matches the name Unity gives the bundle in the AssetBundleManifest, which makes joining against manifest data easier.

Proposed change

  • Pass the scanned root through to SerializedFileParser so archives.name becomes the path relative to that root, with / separators. A file passed directly on the command line keeps its file name, as today.
  • Keep the Duplicate archive name message for genuine duplicates (two builds with the same relative layout).
  • Document the change in Documentation/analyzer-schema.md (archives.name) and Documentation/command-analyze.md. The archive column in object_view changes value for nested bundles, so bump PRAGMA user_version and add a row to the schema version table.
  • Add a test with two bundles of the same file name in different sub-folders of one scanned directory, asserting both archives are recorded with distinct path-based names and that references between them still resolve.

Related: #51 introduced the duplicate-name handling.

Langage dominant
C#
Étoiles
821
Forks
71
Merge moyen
4 h 54 min
PR mergées (30 j)
10

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de Unity-Technologies/UnityDataTools

Toutes les issues de Unity-Technologies/UnityDataTools

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.