Line 194 use ecb. instead of state.EntityManager

Open
#4 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp, unity
Domain
game-dev

Research direction

Open OnlineFPS/Assets/Scripts/GameManagement/ServerGameSystem.cs around line 194 and inspect the surrounding method to confirm the available ecb. Replace the direct state.EntityManager entity creation with ecb.CreateEntity(), then verify the OnlineFPS sample still builds.

Written by the indexing model from the issue text.

Description

https://github.com/Unity-Technologies/CharacterControllerSamples/blob/cbf6e6e628e7baaa8a39d7098a88c658d433df20/OnlineFPS/Assets/Scripts/GameManagement/ServerGameSystem.cs#L194C21-L194C91

Entity joinRequestAcceptedEntity = state.EntityManager.CreateEntity();
should be
Entity joinRequestAcceptedEntity = ecb.CreateEntity();

Dominant language
C#
Stars
408
Forks
67
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Unity-Technologies/CharacterControllerSamples

All issues in Unity-Technologies/CharacterControllerSamples

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.