Improve time codes: status hint doesn't mention the new Shift+F7 / Shift+F8 "to check" navigation

Open Beginner friendly
#16,943 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp
Domain
localization

Research direction

Open src/ui/Logic/Config/Language/Tools/LanguageImproveTimeCodes.cs and edit the two strings named in the issue, LinesToCheckX and LargeMovesToCheckX, keeping the {0} placeholder in place and rewording only the instruction around it. Build the project and run the aligner on a short file, or check the Improve time codes status line directly, to confirm it now names Shift+F8 / Shift+F7. Done means both strings mention the new keys and still read correctly with the line count substituted.

Written by the indexing model from the issue text.

Description

Follow-up to #16624. Thanks for adding Shift+F7 / Shift+F8 - it works well in v5.5.0-beta6.

What's missing

The status line shown at the bottom of the window after aligning still only mentions F5:

29 line(s) are left unticked to check - listen to them (F5 plays the aligned line, Shift+F5 the original) and tick the ones that are right.

The new keys are only discoverable from the tooltips on the amber arrows and from the docs page. Since this line is exactly where the user is told what to do with the flagged rows, it is the natural place to name them. As it stands, the new navigation is there but nothing visible in the window says so.

Suggested wording

LinesToCheckX (and the same change in LargeMovesToCheckX) in src/ui/Logic/Config/Language/Tools/LanguageImproveTimeCodes.cs:

{0} line(s) are left unticked to check - step through them with Shift+F8 / Shift+F7, listen (F5 plays the aligned line, Shift+F5 the original) and tick the ones that are right.

Tested on

  • Windows 11, Subtitle Edit v5.5.0-beta6
  • 2,398-line file, Canary CTC aligner, Max shift 10 s, Check with speech-to-text on
  • Result: 2,338 changed, 29 to check. Plain F8 walks all 2,338; Shift+F8 walks the 29.

The two strings are unchanged on current main as well.

Dominant language
C#
Stars
15k
Forks
1.4k
Avg merge
1h 37m
Merged PRs (30d)
582

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SubtitleEdit/subtitleedit

All issues in SubtitleEdit/subtitleedit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.