[Networking] FFAPI login query handling conflicts with Sponge (indefinite wait / payload discard)
Nobody has claimed this yet.
Assessment
This issue has not been assessed yet.
Description
Minecraft version
1.21.1
Describe the bug
When running a Sponge-powered NeoForge server together with FFAPI, login custom query handling may hang or drop because of FFAPI’s current packet tracking logic
Steps to reproduce
- Install SpongeNeo + FFAPI on a NeoForge 1.21.1 server.
- Let both mods send/expect login queries during handshake.
Observe: Clients hang indefinitely (“waiting for login response”), or Disconnect with Unexpected custom data from client.
Logs
No response
Additional context
When running a Sponge-powered NeoForge server together with FFAPI, login custom query handling may hang or drop because of FFAPI’s current packet tracking logic:
- FFAPI records every outgoing login query (regardless of who sent it).
- On receiving, FFAPI expects to see a response for every recorded query, and tries to handle it.
- If FFAPI fails to handle, it discards the payload content.
This leads to two conflict scenarios with Sponge:
- Sponge handles first → FFAPI never sees the outgoing query, but still expects a response → indefinite wait.
- FFAPI handles first but fails → payload is discarded → Sponge no longer has access to the content → unexpected disconnect.
The issues from Sponge is here: https://github.com/SpongePowered/Sponge/issues/4228#issuecomment-3282821486
I am doing my work (try to write some mods to mixin that cause the problem's code)
If possible, we could try to fix that together.
- Dominant language
- Java
- Stars
- 181
- Forks
- 41
- Avg merge
- 10d 5h
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Sinytra/ForgifiedFabricAPI
-
Missing mixin in fabric-registry-sync-v0 suspected to break modded registry loadingMay be free again @Su5eD claimed this 88 days ago, and no pull request is open. Open26.1.x bug
Sinytra/ForgifiedFabricAPI#280 · 6 comments · 1 assignee ·
-
1.21.x bug
Sinytra/ForgifiedFabricAPI#276 ·
-
1.21.x bug
Sinytra/ForgifiedFabricAPI#269 ·
-
1.21.x bug
Sinytra/ForgifiedFabricAPI#267 ·
-
1.21.x bug
Sinytra/ForgifiedFabricAPI#265 · 6 comments ·
All issues in Sinytra/ForgifiedFabricAPI
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
utopia-rise/godot-jvm#1004 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
spring-projects/spring-grpc#442 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
resilience4j/resilience4j#2547 ·
Maintainers usually reply within 9 days
-
Clock.MakeDate continues execution and returns a rolled-over instant after dispatching error on invalid datePossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 1/5 Under an hour Newbie friendliness 82/100
mit-cml/appinventor-sources#4155 ·
Maintainers usually reply within 1 day