Players are Disconnected when recieving Death Message with Chat Open (incompatibility with Supplementaries)
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 53/100
Research direction
Start with MinecraftClientMixin.java and ScreenEvents.remove, the locations named in the report, then inspect how the death packet is handled when chat is open alongside Supplementaries. Reproduce on Minecraft 1.21.1 with Forgified Fabric API and Supplementaries; done means dying with chat open no longer disconnects the player.
Written by the indexing model from the issue text.
Description
Minecraft version
1.21.1
Describe the bug
Dying with Chat Open Crashes Game
Steps to reproduce
- Play with the Forgified Fabric API.
- Install Supplementaries. I tested it without supplementaries and the error doesn't occur, but the error originates from the onScreenRemove function, which is likely not called by Supplementaries.
- Place yourself at a Y level high off the ground and die with chat open.
- Causes error upon the death packet being received:
[Server thread/INFO][net.minecraft.server.MinecraftServer/]: PlayerName fell from a high place
[Render thread/ERROR][net.minecraft.client.multiplayer.ClientCommonPacketListenerImpl/]: Failed to handle packet ClientboundPlayerCombatKillPacket[playerId=79, message=translation{key='death.fell.accident.generic', args=[empty[style={clickEvent=ClickEvent{action=SUGGEST_COMMAND, value='/tell PlayerName '},hoverEvent=TypedHoverEvent[action=<action show_entity>, value=net.minecraft.network.chat.HoverEvent$EntityTooltipInfo@aff16f4a],insertion=PlayerName}, siblings=[literal{PlayerName}]]]}]
java.lang.NullPointerException: Screen cannot be null
at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]
at TRANSFORMER/[email protected]+4228281319/net.fabricmc.fabric.api.client.screen.v1.ScreenEvents.remove(ScreenEvents.java:111) ~[fabric-screen-api-v1-2.0.25+4228281319.jar%23428!/:2.0.25+4228281319]
- Player is booted back to the multiplayer menu, even in singleplayer.
Logs
Additional context
This issue has already been reported to the Supplementaries developers and marked as not an issue on their end, then moved to this Forgified Fabric API issue, but judging by the comments saying that it is still an issue months after its fix I'm assuming issues here aren't reopened and a new one needs to be made.
- Dominant language
- Java
- Stars
- 181
- Forks
- 41
- Avg merge
- 10d 5h
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Sinytra/ForgifiedFabricAPI
-
Missing mixin in fabric-registry-sync-v0 suspected to break modded registry loadingMay be free again @Su5eD claimed this 89 days ago, and no pull request is open. Open26.1.x bug
Sinytra/ForgifiedFabricAPI#280 · 6 comments · 1 assignee ·
-
1.21.x bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Sinytra/ForgifiedFabricAPI#276 ·
-
1.21.x bug
Difficulty 4/5 3-5 days Newbie friendliness 42/100
Sinytra/ForgifiedFabricAPI#269 ·
-
1.21.x bug
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Sinytra/ForgifiedFabricAPI#265 · 6 comments ·
-
1.21.x bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Sinytra/ForgifiedFabricAPI#263 · 2 comments ·
All issues in Sinytra/ForgifiedFabricAPI
Similar issues
-
Use GHA setup gradle actionPossibly taken @bric3 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
openhab/openhab-addons#21921 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
jellyfin/jellyfin-androidtv#5885 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
priority:P2 product:orazaka type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day