[Networking] FFAPI login query handling conflicts with Sponge (indefinite wait / payload discard)

Aberta
  • Algo errado?
#241 1 comentário 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Estagnada
Stack de tecnologia
java
Domínio
backend, networking

Direção de pesquisa

Start by tracing FFAPI's login query packet tracking and response handling described in the issue, then compare that flow with Sponge's handling in the linked Sponge issue. Reproduce on a NeoForge 1.21.1 server with Sponge and FFAPI installed. Done means login queries are handled without hanging clients or discarding payloads needed by Sponge.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

1.21.x bug
Minecraft version

1.21.1

Describe the bug

When running a Sponge-powered NeoForge server together with FFAPI, login custom query handling may hang or drop because of FFAPI’s current packet tracking logic

Steps to reproduce
  1. Install SpongeNeo + FFAPI on a NeoForge 1.21.1 server.
  2. Let both mods send/expect login queries during handshake.

Observe: Clients hang indefinitely (“waiting for login response”), or Disconnect with Unexpected custom data from client.

Logs

No response

Additional context

When running a Sponge-powered NeoForge server together with FFAPI, login custom query handling may hang or drop because of FFAPI’s current packet tracking logic:

  • FFAPI records every outgoing login query (regardless of who sent it).
  • On receiving, FFAPI expects to see a response for every recorded query, and tries to handle it.
  • If FFAPI fails to handle, it discards the payload content.

This leads to two conflict scenarios with Sponge:

  • Sponge handles first → FFAPI never sees the outgoing query, but still expects a response → indefinite wait.
  • FFAPI handles first but fails → payload is discarded → Sponge no longer has access to the content → unexpected disconnect.

The issues from Sponge is here: https://github.com/SpongePowered/Sponge/issues/4228#issuecomment-3282821486

I am doing my work (try to write some mods to mixin that cause the problem's code)

If possible, we could try to fix that together.

Linguagem predominante
Java
Estrelas
181
Forks
41
Merge médio
16h 38min
PRs com merge (30d)
1

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de Sinytra/ForgifiedFabricAPI

Todas as issues de Sinytra/ForgifiedFabricAPI

Issues semelhantes

Mais issues de Java

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.