Draw: remove inactive palette settings from unified Workbench
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
Research direction
Start with the embedded setup in Sources/StageKit/StageKitController.swift, the Draw settings in Sources/StageKit/Views.swift, and the visibility gate in Sources/StageKit/AppCoordinator.swift. Check the surface registry and shared help for entries tied to the two palette options and auto-hide instructions, then run the relevant surface-registry checks. Done means those inactive controls and stale references are gone from unified Workbench, remaining Draw options have observable effects, and the specified drawing, board, and preference behavior is preserved and verified natively.
Written by the indexing model from the issue text.
Description
Outcome and evidence
P2, source-confirmed inert settings. The Draw page offers “Show the palette while drawing” and “Board palette” choices, but the unified app suppresses the legacy palette regardless of those values.
The drawing-palette checkbox was observed in the installed app. Its toggle/board variants were not exercised, so this is a source finding, not a measured native before/after result.
Workbench Preview 2.3.0, build 20260928054038, source 00be555139f87d4557f48fcffc132b8621c251a2, unmodified source, macOS 26.5.1 (25F80), Apple M5, built-in display. Identity verified in the running app using Copy build details on 28 September 2026.
Owner and bounded change
Source links below pin the earlier audited commit 9578d8cf; the relevant paths were checked against installed 00be5551 and the described behaviour is unchanged. Source findings and native observations are distinguished below.
- StageKitController.swift constructs the coordinator with embedded true.
- Views.swift exposes the drawing-palette checkbox; lines 246–247 expose Board palette and auto-hide instructions.
- AppCoordinator.swift gates palette visibility on !embedded.
- No reader of these preferences was found in the unified LocalVoice/ToolbarCore/ToolbarKit surfaces at the audited revision.
Decision
Remove Show the palette while drawing, Board palette, and their obsolete auto-hide instructions from the embedded unified Workbench page. They do not control its shared toolbar. Keep one drawing control surface and the existing toolbar's behaviour. Preserve stored preference values and any non-embedded legacy use; this is a visible-control removal, not a destructive preference migration.
Do not add a second palette or wire these old controls to unrelated toolbar semantics. The implementing agent updates the surface registry and shared help where required.
Acceptance
- Those inactive controls and their auto-hide instructions are absent from unified Workbench. Every remaining visible Draw option has an observable effect.
- Removed options leave no stale help text or inaccessible shortcut/settings entry.
- Start/stop drawing and board workflows keep their appropriate controls reachable.
- Existing ink, boards, user placement and unrelated preferences remain unchanged.
- Verify native before/after with a disposable board and restore test preferences.
- Run relevant surface-registry checks for any renamed/removed clickable entry.
Bounded work under #134's Draw tidy, related #56.
- Dominant language
- Swift
- Stars
- 0
- Forks
- 1
- Avg merge
- 8h 5m
- Merged PRs (30d)
- 215
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Ship-Work/workbench
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
documentation good first issue help wanted
Difficulty 2/5 Half a day Newbie friendliness 74/100
Ship-Work/workbench#29 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
Maintainers usually reply within 1 day
All issues in Ship-Work/workbench
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
deltachat/deltachat-ios#3388 ·
Maintainers usually reply within 1 day
-
desktop-app
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
raullenchai/Rapid-MLX#4975 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
xybrid-ai/xybrid#661 · 1 comment ·
Maintainers usually reply within 1 day
-
stdlib
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
altic-dev/FluidVoice#1191 ·
Maintainers usually reply within 1 day