Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Draw: remove inactive palette settings from unified Workbench

Aperta
  • Qualcosa non va?
#160 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
macos, swift
Ambito
desktop

Direzione di ricerca

Start with the embedded setup in Sources/StageKit/StageKitController.swift, the Draw settings in Sources/StageKit/Views.swift, and the visibility gate in Sources/StageKit/AppCoordinator.swift. Check the surface registry and shared help for entries tied to the two palette options and auto-hide instructions, then run the relevant surface-registry checks. Done means those inactive controls and stale references are gone from unified Workbench, remaining Draw options have observable effects, and the specified drawing, board, and preference behavior is preserved and verified natively.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Outcome and evidence

P2, source-confirmed inert settings. The Draw page offers “Show the palette while drawing” and “Board palette” choices, but the unified app suppresses the legacy palette regardless of those values.

The drawing-palette checkbox was observed in the installed app. Its toggle/board variants were not exercised, so this is a source finding, not a measured native before/after result.

Workbench Preview 2.3.0, build 20260928054038, source 00be555139f87d4557f48fcffc132b8621c251a2, unmodified source, macOS 26.5.1 (25F80), Apple M5, built-in display. Identity verified in the running app using Copy build details on 28 September 2026.

Owner and bounded change

Source links below pin the earlier audited commit 9578d8cf; the relevant paths were checked against installed 00be5551 and the described behaviour is unchanged. Source findings and native observations are distinguished below.

  • StageKitController.swift constructs the coordinator with embedded true.
  • Views.swift exposes the drawing-palette checkbox; lines 246–247 expose Board palette and auto-hide instructions.
  • AppCoordinator.swift gates palette visibility on !embedded.
  • No reader of these preferences was found in the unified LocalVoice/ToolbarCore/ToolbarKit surfaces at the audited revision.

Decision

Remove Show the palette while drawing, Board palette, and their obsolete auto-hide instructions from the embedded unified Workbench page. They do not control its shared toolbar. Keep one drawing control surface and the existing toolbar's behaviour. Preserve stored preference values and any non-embedded legacy use; this is a visible-control removal, not a destructive preference migration.

Do not add a second palette or wire these old controls to unrelated toolbar semantics. The implementing agent updates the surface registry and shared help where required.

Acceptance

  • Those inactive controls and their auto-hide instructions are absent from unified Workbench. Every remaining visible Draw option has an observable effect.
  • Removed options leave no stale help text or inaccessible shortcut/settings entry.
  • Start/stop drawing and board workflows keep their appropriate controls reachable.
  • Existing ink, boards, user placement and unrelated preferences remain unchanged.
  • Verify native before/after with a disposable board and restore test preferences.
  • Run relevant surface-registry checks for any renamed/removed clickable entry.

Bounded work under #134's Draw tidy, related #56.

Lingua principale
Swift
Stelle
0
Fork
1
Merge medio
13h 40m
PR unite (30g)
221

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Ship-Work/workbench

Tutte le issue di Ship-Work/workbench

Issue simili

Altre issue su Swift

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.