[Bug] [libc] settimeofday 在 time64/long32 配置下窄化校验,错误拒绝有效时间戳

Open
#11,922 4 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 2 days

@Yunlk is already working on this.

Since Oct 24, 2026.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
c

Research direction

Read components/libc/compilers/common/ctime.c, especially settimeofday() around lines 559–599, and inspect the field types used by its validation and the RTC control calls. Reproduce the narrowing behavior with the stated time64/long32 ARM configuration or a focused test. Done when a valid positive timestamp such as 2208988800 passes entry validation and reaches the RTC driver; hardware support determines whether the driver accepts it.

Written by the indexing model from the issue text.

Description

in progress
RT-Thread Version

master, commit a59e72fb5c2f272761a2813fc9bd9fe18eb29d7d.

Affected area

libc / RTC, components/libc/compilers/common/ctime.c, settimeofday().

Hardware / Architecture / Toolchain

32 位 ARM ABI:time_t 为 64 位有符号类型,long 为 32 位。工具链为 GNU Arm Embedded Toolchain 10.3-2021.10(newlib)。已通过隔离的 ARM 编译验证类型大小及窄化转换行为;尚未验证已部署固件,不代表已经完成实机测试。

问题描述 / Describe the bug

settimeofday() 在验证时间戳时先强制转换为 long:

if (tv != RT_NULL && (long)tv->tv_usec >= 0 && (long)tv->tv_sec >= 0)

在 time64/long32 配置下,有效的正时间戳可能因此变成负数,在调用 RTC 驱动之前就返回 -1、设置 errno=EINVAL。

固定版本源码 L559–599

复现 / Reproduction

在上述 ABI 下启用 RT_USING_RTC,并提供能接受该时间的 RTC 设备:

#include <time.h>
#include <sys/time.h>
#include <errno.h>

_Static_assert(sizeof(time_t) == 8, "requires time64");
_Static_assert(sizeof(long) == 4, "requires long32");

struct timeval tv = {0};
tv.tv_sec = (time_t)2208988800LL; /* 2040-01-01 00:00:00 UTC */
tv.tv_usec = 0;
int rc = settimeofday(&tv, NULL);

预期:该有效正时间应通过入口校验,由 RTC 驱动决定是否支持设置。

源码推导结果:测试所用 ARM GCC 的 (long)2208988800LL 为 -2085978496,入口条件为假,因此两个 RTC control 操作均不会被调用,返回 -1/EINVAL。

验证边界:已隔离编译确认类型大小及强转后的判断结果,尚未在目标板上端到端执行上面的调用。超范围有符号转换的结果取决于实现;这里的数值针对已验证的 GCC 行为。并非所有 2038 年之后的时间都会被拒绝:在该行为下首个拒绝区间为秒值 2147483648..4294967295。

Suggested direction

避免为了检查符号而将 tv_sec 窄化为 long,按字段自身的类型进行范围验证。该问题不限于 picolibc,time64/long32 的 newlib 配置同样可能受影响。它与 time32 本身的表示范围限制是两个独立问题。

引入提交和版本 / Regression history
  • 引入该窄化检查的提交:92859cc79e,2023-08-07,[libc][time] silence the incorrect type warning。
  • 该提交将原先直接比较字段的表达式改成 (long) 强转;首个包含它的正式 release 为 v5.0.2。
  • 这是条件性回归:只有字段类型与 long 的宽度/表示范围不匹配并输入对应时间戳时才暴露,并非从该版本开始所有平台都不能设置时间。
其他实现参考 / Comparison

这里只比较有效正时间戳的传递方式,不主张所有 OS 的设置时间权限、负值策略或硬件支持范围相同。

Dominant language
C
Stars
12.4k
Forks
5.5k
Avg merge
3d 7h
Merged PRs (30d)
79

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RT-Thread/rt-thread

All issues in RT-Thread/rt-thread

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.