Items on crafted bases missing from Data/Bases (e.g. Runemastered Long Quarterstaff) are silently dropped

Open
#2,582 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@vaisest is already working on this.

Since Nov 5, 2026.

  • #2583 by @vaisest — open

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
lua
Domain
backend

Research direction

Start by comparing the crafted base names in Data/VerisiumCrafts.lua with entries in Data/Bases/*.lua, then read the item loading path in Classes/ItemsTab.lua around the cited line. Check how repeated base keys with multiple implicits are handled, using Runemastered Runic Fork as an example. Done means the listed bases are recognized and their intended implicits survive loading; verify with the custom Pillar of the Caged God item described in the issue.

Written by the indexing model from the issue text.

Description

Check version
  • I'm running the latest version of Path of Building (dev at bb52d6b, 2026-10-01)
Check for duplicates
  • I've checked for duplicate open and closed issues (searched "Runemastered", "Long Quarterstaff", "missing base runeforged")
Check for support
  • Crafted Verisium bases are supported (Data/VerisiumCrafts.lua, itemLib.addRuneforgingBaseVariants)
What platform are you running Path of Building on?

macOS (headless, from the source); the cause is in the data, so it should be the same on every platform.

What is the behaviour in-game?

A character has a Pillar of the Caged God on a Runemastered Long Quarterstaff equipped in weapon set 1. poe.ninja shows it on the character.

What is the behaviour in Path of Building?

The weapon is gone: the build opens with both weapon slots empty, and the main skill (Storm Wave, a Quarterstaff skill) shows 0 DPS. The PoB code that poe.ninja exports for the character already has no weapon item, probably because the exporter also uses PoB's data.

Cause. Data/VerisiumCrafts.lua lists crafted bases that have no entry in Data/Bases/*.lua. When an item's base is not in data.itemBases, ItemsTab:Load keeps it only if item.base then (Classes/ItemsTab.lua, around line 1275), so the item is dropped without any message.

These are the crafted bases named in VerisiumCrafts.lua but missing from Data/Bases/ on the current dev:

Runeforged Crescent Quarterstaff   <- Crescent Quarterstaff
Runeforged Gothic Quarterstaff     <- Gothic Quarterstaff
Runeforged Long Quarterstaff       <- Long Quarterstaff
Runeforged Steelpoint Quarterstaff <- Steelpoint Quarterstaff
Runeforged Wrapped Quarterstaff    <- Wrapped Quarterstaff
Runemastered Gothic Quarterstaff   <- Runeforged Gothic Quarterstaff
Runemastered Long Quarterstaff     <- Runeforged Long Quarterstaff
The Triskelion Reforged            <- Shattered Triskelion

Every Runeforged quarterstaff is missing. The only crafted quarterstaff in Data/Bases/staff.lua is Runemastered Warding Quarterstaff.

A related data issue: when a crafted base can have several implicits, Data/Bases/*.lua defines the same key once per implicit. For example, itemBases["Runemastered Runic Fork"] appears three times: Spell projectiles, Mana Regeneration and Runic Ward. Only the last definition survives in data.itemBases, so the base's own implicit is always the Runic Ward one.

How to reproduce the issue
  1. Items tab → "Create custom", paste:
    Rarity: Unique
    Pillar of the Caged God
    Runemastered Long Quarterstaff
    Implicits: 1
    16% increased Melee Strike Range with this weapon
    10% increased Weapon Damage per 10 Strength
    
    PoB does not recognise the base (the parsed item has no base). With Long Quarterstaff as the base, the same item works.
  2. Or load any build XML with that item in Weapon 1: the slot comes back empty.
PoB for PoE2 build code

Not attached: the code exported by poe.ninja already lacks the weapon. The item above reproduces it.

Dominant language
Lua
Stars
1.9k
Forks
469
Avg merge
3m
Merged PRs (30d)
1

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PathOfBuildingCommunity/PathOfBuilding-PoE2

All issues in PathOfBuildingCommunity/PathOfBuilding-PoE2

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.